Summary: | UNIMARC XSLT Update for bug 7611 | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | OPAC | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | didier.gautheron, fridolin.somers, jean-manuel.broust, jonathan.druart, kyle, severine.queune |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.05.00
|
|
Circulation function: | |||
Bug Depends on: | 7611 | ||
Bug Blocks: | |||
Attachments: |
Bug 24630: UNIMARC XSLT changes for bug 7611
Bug 24630: UNIMARC XSLT changes for bug 7611 Bug 24630: UNIMARC XSLT changes for bug 7611 Bug 24630: (follow-up 1) fix indenting Bug 24630: (follow-up 2) call number when singleBranchMode=1 Bug 24630: (follow-up 2) call number when singleBranchMode=1 |
Description
Nick Clemens (kidclamp)
2020-02-11 14:18:02 UTC
Created attachment 98709 [details] [review] Bug 24630: UNIMARC XSLT changes for bug 7611 Follow test plan from 7611 on a UNIMARC system. These changes have not been tested by me Created attachment 107462 [details] [review] Bug 24630: UNIMARC XSLT changes for bug 7611 Follow test plan from 7611 on a UNIMARC system. These changes have not been tested by me I start testing, looks good I see it adds callnumber with classes like in MARC21 : <span class="CallNumberAndLabel"> <span class="LabelCallNumber">Call number: </span> <span class="CallNumber"><xsl:value-of select="items:itemcallnumber"/></span> </span> This is really great for styling. But I see [] are added by CSS : .ItemSummary .LabelCallNumber:before { content:" [" } .ItemSummary .CallNumber:after { content:"]" } In this case [ disappears if you hide LabelCallNumber. Shouldn't it be : .ItemSummary .CallNumberAndLabel:before { content:" [" } .ItemSummary .CallNumberAndLabel:after { content:"]" } I'll create another bug report it confirmed. Created attachment 116578 [details] [review] Bug 24630: UNIMARC XSLT changes for bug 7611 Follow test plan from 7611 on a UNIMARC system. These changes have not been tested by me Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Created attachment 116579 [details] [review] Bug 24630: (follow-up 1) fix indenting Created attachment 116580 [details] [review] Bug 24630: (follow-up 2) call number when singleBranchMode=1 singleBranchMode=1 is when there is only one library (branch). Test disply of available item. Patch allows display of call number like in regular mode I've signed main patch and added 2 followups Created attachment 128935 [details] [review] Bug 24630: (follow-up 2) call number when singleBranchMode=1 singleBranchMode=1 is when there is only one library (branch). Test disply of available item. Patch allows display of call number like in regular mode Signed-off-by: Florian Bontemps <florian.bontemps@biblibre.com> No UNIMARC user in the QA team, trusting author and testers. Pushed to master for 22.05, thanks to everybody involved [U+1F984] |