Add some classes and display authorized values for notforloan statuses based on work from bug 7611
Created attachment 98709 [details] [review] Bug 24630: UNIMARC XSLT changes for bug 7611 Follow test plan from 7611 on a UNIMARC system. These changes have not been tested by me
Created attachment 107462 [details] [review] Bug 24630: UNIMARC XSLT changes for bug 7611 Follow test plan from 7611 on a UNIMARC system. These changes have not been tested by me
I start testing, looks good
I see it adds callnumber with classes like in MARC21 : <span class="CallNumberAndLabel"> <span class="LabelCallNumber">Call number: </span> <span class="CallNumber"><xsl:value-of select="items:itemcallnumber"/></span> </span> This is really great for styling. But I see [] are added by CSS : .ItemSummary .LabelCallNumber:before { content:" [" } .ItemSummary .CallNumber:after { content:"]" } In this case [ disappears if you hide LabelCallNumber. Shouldn't it be : .ItemSummary .CallNumberAndLabel:before { content:" [" } .ItemSummary .CallNumberAndLabel:after { content:"]" } I'll create another bug report it confirmed.
Created attachment 116578 [details] [review] Bug 24630: UNIMARC XSLT changes for bug 7611 Follow test plan from 7611 on a UNIMARC system. These changes have not been tested by me Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Created attachment 116579 [details] [review] Bug 24630: (follow-up 1) fix indenting
Created attachment 116580 [details] [review] Bug 24630: (follow-up 2) call number when singleBranchMode=1 singleBranchMode=1 is when there is only one library (branch). Test disply of available item. Patch allows display of call number like in regular mode
I've signed main patch and added 2 followups
Created attachment 128935 [details] [review] Bug 24630: (follow-up 2) call number when singleBranchMode=1 singleBranchMode=1 is when there is only one library (branch). Test disply of available item. Patch allows display of call number like in regular mode Signed-off-by: Florian Bontemps <florian.bontemps@biblibre.com>
No UNIMARC user in the QA team, trusting author and testers.
Pushed to master for 22.05, thanks to everybody involved [U+1F984]