| Summary: | Add ability to run cash register report with new cash register feature | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kelly McElligott <kelly> |
| Component: | Reports | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | andrew, jonathan.druart, lucas, sally.healey |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This enhancement exposes the ability to refine the cash register report by cash register the transactions have taken place upon if you are using the 'UseCashRegisters' feature.
|
Version(s) released in: |
20.11.00
|
| Circulation function: | |||
| Bug Depends on: | 24786 | ||
| Bug Blocks: | 13985 | ||
| Attachments: |
Bug 24665: Add support for filtering by cash register
Bug 24665: Add support for filtering by cash register Bug 24665: Add support for filtering by cash register Bug 24665: Add support for filtering by cash register Bug 24665: Add support for filtering by cash register Bug 24665: (QA follow-up) Fix selection default Bug 24665: (QA follow-up) Add tests for 'selected' |
||
|
Description
Kelly McElligott
2020-02-14 14:44:39 UTC
What did you have in mind Kelly... I must admit, I've never really used that report. Having just taken a look at it, are you simply suggesting adding the ability to limit the results by a particular cash register via a select menu? Created attachment 107150 [details] [review] Bug 24665: Add support for filtering by cash register Didn't get much of a brief here, so I've just added filtering for now, but let me know what additional requirements you might have.. I wasn't sure if you also wanted it in the standard output of the report too? Created attachment 107164 [details] [review] Bug 24665: Add support for filtering by cash register Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Martin, Great! This will be helpful to those libraries that use this built in report! Of course any other type of report if needed can be created using MySql in the Koha report module. Blocked by depending bug 24786 currently in need of a sign-off! Dont' suppose you fancied testing/signing off on bug 24786 did you Kelly? It's a dependency here so you effectively tested it whilst testing this one. Created attachment 112901 [details] [review] Bug 24665: Add support for filtering by cash register Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Rebased, ready for QA Created attachment 112960 [details] [review] Bug 24665: Add support for filtering by cash register This patch makes it possible to filter on cash register on the cash register statistics page. To test: - Activate UseCashRegisters - Create a cash register or more to use - Create some manual fees and fines - Pay some of them off - Go to Tools > Cash register statistics - Test if the new filter for cash registers works as it should Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> "--None--" is actually a "All" filter. Should not it be "All" or "" instead? (In reply to Jonathan Druart from comment #11) > "--None--" is actually a "All" filter. > Should not it be "All" or "" instead? Hmm, fair comment.. challenge is that the default value comes from the html_helper. I've already worked around this once in the dependency bug as the same issue was present on the login page (i.e Library default vs '--None--'. I'll take a look at simplifying it here Created attachment 113247 [details] [review] Bug 24665: Add support for filtering by cash register This patch makes it possible to filter on cash register on the cash register statistics page. To test: - Activate UseCashRegisters - Create a cash register or more to use - Create some manual fees and fines - Pay some of them off - Go to Tools > Cash register statistics - Test if the new filter for cash registers works as it should Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 113248 [details] [review] Bug 24665: (QA follow-up) Fix selection default This patch updates the html_helper for the cash register selection block to remove the 'empty option' such that it can be correclty set for each select case and updates all existing cases where we used the process block previously to include the relevant blank option '-- Select an option --', '-- None --', 'Library default' and finally the new '-- All --' options introduced with this bug. :) - Much cleaner now. Pushed to master for 20.11, thanks to everybody involved! Created attachment 113261 [details] [review] Bug 24665: (QA follow-up) Add tests for 'selected' Add a unit test to prove the 'selected' param passed to Koha::Template::Plugin::Registers is adhered to. (In reply to Martin Renvoize from comment #17) > Created attachment 113261 [details] [review] [review] > Bug 24665: (QA follow-up) Add tests for 'selected' > > Add a unit test to prove the 'selected' param passed to > Koha::Template::Plugin::Registers is adhered to. Pushed to master for 20.11. enhancement will not be backported to 20.05.x |