Bug 24786 - Allow setting a cash register for a login session
Summary: Allow setting a cash register for a login session
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Fines and fees (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Martin Renvoize
QA Contact: Testopia
URL:
Keywords:
Depends on: 24201 23321
Blocks: 24665 26177
  Show dependency treegraph
 
Reported: 2020-03-03 11:37 UTC by Martin Renvoize
Modified: 2020-08-07 13:26 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 24786: Allow setting a register for the session (19.08 KB, patch)
2020-07-21 12:42 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24786: Allow selection of cash register at login (5.22 KB, patch)
2020-07-21 12:42 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24786: Update point of sale to use session register (5.17 KB, patch)
2020-07-21 12:42 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24786: Update paycollect to use session register (7.07 KB, patch)
2020-07-21 12:42 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24786: Update borroaccount to use session register (5.76 KB, patch)
2020-07-21 12:42 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24786: Allow setting a register for the session (18.94 KB, patch)
2020-08-04 10:35 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24786: Allow selection of cash register at login (5.22 KB, patch)
2020-08-04 10:36 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24786: Update point of sale to use session register (5.17 KB, patch)
2020-08-04 10:36 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24786: Update paycollect to use session register (7.07 KB, patch)
2020-08-04 10:36 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24786: Update borroaccount to use session register (5.76 KB, patch)
2020-08-04 10:36 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24786: Allow setting a register for the session (19.81 KB, patch)
2020-08-04 12:53 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24786: Allow selection of cash register at login (3.70 KB, patch)
2020-08-04 12:53 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24786: Update point of sale to use session register (5.17 KB, patch)
2020-08-04 12:53 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24786: Update paycollect to use session register (7.08 KB, patch)
2020-08-04 12:53 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24786: Update borroaccount to use session register (5.76 KB, patch)
2020-08-04 12:54 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24786: (follow-up) Cache the register_name in the session (9.56 KB, patch)
2020-08-04 12:54 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24786: Allow setting a register for the session (22.14 KB, patch)
2020-08-07 13:26 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24786: Allow selection of cash register at login (3.70 KB, patch)
2020-08-07 13:26 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24786: Update point of sale to use session register (5.17 KB, patch)
2020-08-07 13:26 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24786: Update paycollect to use session register (7.08 KB, patch)
2020-08-07 13:26 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24786: Update borroaccount to use session register (5.76 KB, patch)
2020-08-07 13:26 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24786: (follow-up) Cache the register_name in the session (9.56 KB, patch)
2020-08-07 13:26 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2020-03-03 11:37:37 UTC
If enabled, the cash register associated with any transaction needs to be selected for each and every transaction.  One can use a 'branch default' to set the most likely register for all transactions at a branch, but it would be an improvement to also allow for selecting a different till for the entirety of a login session.

This enhancement aims to add that ability, allowing for a session register to be selected at any point during a session and override the branch default for that session.

One should still be able to override the register per transaction if required.
Comment 1 Martin Renvoize 2020-07-21 12:42:14 UTC Comment hidden (obsolete)
Comment 2 Martin Renvoize 2020-07-21 12:42:17 UTC Comment hidden (obsolete)
Comment 3 Martin Renvoize 2020-07-21 12:42:20 UTC Comment hidden (obsolete)
Comment 4 Martin Renvoize 2020-07-21 12:42:23 UTC Comment hidden (obsolete)
Comment 5 Martin Renvoize 2020-07-21 12:42:25 UTC Comment hidden (obsolete)
Comment 6 Sally 2020-07-24 14:20:30 UTC
Sorry Martin - patch doesn't apply with the following conflict:  

CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/set-library.tt
Comment 7 Martin Renvoize 2020-08-04 10:35:58 UTC Comment hidden (obsolete)
Comment 8 Martin Renvoize 2020-08-04 10:36:01 UTC Comment hidden (obsolete)
Comment 9 Martin Renvoize 2020-08-04 10:36:05 UTC Comment hidden (obsolete)
Comment 10 Martin Renvoize 2020-08-04 10:36:08 UTC Comment hidden (obsolete)
Comment 11 Martin Renvoize 2020-08-04 10:36:11 UTC Comment hidden (obsolete)
Comment 12 Martin Renvoize 2020-08-04 10:36:29 UTC
Rebased
Comment 13 Martin Renvoize 2020-08-04 11:11:51 UTC
Hold off testing here until the next upload.. I'm going to rebase it upon bug 24201 as that's nearly hit PQA now.
Comment 14 Martin Renvoize 2020-08-04 12:53:47 UTC Comment hidden (obsolete)
Comment 15 Martin Renvoize 2020-08-04 12:53:50 UTC Comment hidden (obsolete)
Comment 16 Martin Renvoize 2020-08-04 12:53:54 UTC Comment hidden (obsolete)
Comment 17 Martin Renvoize 2020-08-04 12:53:57 UTC Comment hidden (obsolete)
Comment 18 Martin Renvoize 2020-08-04 12:54:00 UTC Comment hidden (obsolete)
Comment 19 Martin Renvoize 2020-08-04 12:54:03 UTC Comment hidden (obsolete)
Comment 20 Martin Renvoize 2020-08-04 12:55:03 UTC
This should be ready for testing again now.
Comment 21 Martin Renvoize 2020-08-07 13:26:38 UTC
Created attachment 107957 [details] [review]
Bug 24786: Allow setting a register for the session

This patch adds the ability to set a register for the current session
from the 'set library' page.

Upon entering the page, the current selection will be displayed.
Changing the branch will trigger the register select list to update to
display only those registers associated with the updated branch and will
automatically select either 'no register' or the 'branch default'
register.  The user can then override that selection to choose a
different register for the session.

Test plan
1/ Enable cash registers with the 'UseCashRegisters' system preference
2/ Select the 'Set library' option from the top right menu
3/ Note that you can now select a cash register from the subsequent page
4/ Change the branch and note that the cash register selection is
updated to reflect the change
5/ Note that the 'branch default' register is auto-selected upon branch
selection if one has been defined, otherwise '-- None --' is selected
6/ You can then alter the selection before submitting the form
7/ Once submitted note that you are returned to the page you were on
prior to attempting to change the library and register
8/ Note the present of the register name next to the library name at the
top of the screen.
9/ Signoff
Comment 22 Martin Renvoize 2020-08-07 13:26:41 UTC
Created attachment 107958 [details] [review]
Bug 24786: Allow selection of cash register at login
Comment 23 Martin Renvoize 2020-08-07 13:26:44 UTC
Created attachment 107959 [details] [review]
Bug 24786: Update point of sale to use session register

This patch adds handling to allow for the use of the session cash
register by default if it has been set, otherwise it defaults to '--
None --' and requires the end user to select the register to proceed
with the sale.

Test plan
1/ Enable cash registers via the 'UseCashRegisters' system preference
2/ Enable point of sale via the 'EnablePointOfSale' system preference
3/ Navigate to the point of sale page
4/ Note that if you are logged in at a branch with no cash registers yet
defined, then an alert should appear
5/ Note that when you are logged in at a branch with cash regsiters
defined, but without a cash register associated with your session then
the cash 'Cash register' select box is populated with '-- None --' and
you are required to select a register prior to submission
6/ Note that upon selection, the '-- None --' option is disabled
7/ Note that when you have a register associated with your session then
the 'Cash register' select box is pre-populated with that register.
8/ Signoff
Comment 24 Martin Renvoize 2020-08-07 13:26:48 UTC
Created attachment 107960 [details] [review]
Bug 24786: Update paycollect to use session register

This patch adds handling to allow for the use of the session cash
register by default if it has been set, otherwise it defaults to '--
None --' and requires the end user to select the register to proceed
with the payment.
Comment 25 Martin Renvoize 2020-08-07 13:26:51 UTC
Created attachment 107961 [details] [review]
Bug 24786: Update borroaccount to use session register

This patch adds handling to allow for the use of the session cash
register by default if it has been set, otherwise it defaults to '--
None --' and requires the end user to select the register to proceed
with the refund or payout action.
Comment 26 Martin Renvoize 2020-08-07 13:26:55 UTC
Created attachment 107962 [details] [review]
Bug 24786: (follow-up) Cache the register_name in the session

This leads to one DB hit less per page load in the staff client when
cash registers are enabled.