Summary: | Typo in circulation.js | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | 1joynelson, bgkriegel, joonas.kylmala, kyle, lucas, martin.renvoize |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.04
|
|
Circulation function: | |||
Bug Depends on: | 14697 | ||
Bug Blocks: | 24725 | ||
Attachments: |
Bug 24727: (bug 14697 follow-up) Fix typo in script name
Bug 24727: (bug 14697 follow-up) Fix typo in script name Bug 24727: (bug 14697 follow-up) Fix typo in script name Bug 24727: (bug 14697 follow-up) Replace link on title to bib detail page Bug 24727: (bug 14697 follow-up) Replace link on title to bib detail page |
Description
Jonathan Druart
2020-02-25 13:16:30 UTC
Created attachment 99579 [details] [review] Bug 24727: (bug 14697 follow-up) Fix typo in script name 903 let title = `<a class="return-claim-title strong" href="/cgi-bin/koha/circ/request-rcticle.pl?biblionumber=[% rc.checkout.item.biblionumber | html %]"> request-rcticle.pl vs request-acticle.pl Test plan: cf bug 14697 Test plan: - Have something in the claim table (cf bug 14697) - Click on the title of the bibliographic record Created attachment 99581 [details] [review] Bug 24727: (bug 14697 follow-up) Fix typo in script name 903 let title = `<a class="return-claim-title strong" href="/cgi-bin/koha/circ/request-rcticle.pl?biblionumber=[% rc.checkout.item.biblionumber | html %]"> request-rcticle.pl vs request-acticle.pl Test plan: - Have something in the claim table (cf bug 14697) - Click on the title of the bibliographic record We actually want to link to the detail page, right? (In reply to Jonathan Druart from comment #4) > We actually want to link to the detail page, right? I don't have the answer, but the fix shouldn't have been: href="/cgi-bin/koha/circ/request-article.pl?biblionumber=[% rc.checkout.item.biblionumber | html %] i.e. rcticle -> article? On the other hand, I see that sometimes [% biblionumber | html ] is used, and other times [% biblionumber | uri %]. It's the same? (In reply to Jonathan Druart from comment #4) > We actually want to link to the detail page, right? Yeah, that looks like a copy/paste or rebase error to me.. I think you're right.. it should be the biblio detail link. Latest patch looks good to me.. looks like you've handled the backticks issue in bug 24725.. thanks :) Created attachment 99588 [details] [review] Bug 24727: (bug 14697 follow-up) Fix typo in script name 903 let title = `<a class="return-claim-title strong" href="/cgi-bin/koha/circ/request-rcticle.pl?biblionumber=[% rc.checkout.item.biblionumber | html %]"> request-rcticle.pl vs request-acticle.pl Test plan: - Have something in the claim table (cf bug 14697) - Click on the title of the bibliographic record Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> The patch commit message doesn't describe the change. Failing QA. Created attachment 99632 [details] [review] Bug 24727: (bug 14697 follow-up) Replace link on title to bib detail page 903 let title = `<a class="return-claim-title strong" href="/cgi-bin/koha/circ/request-rcticle.pl?biblionumber=[% rc.checkout.item.biblionumber | html %]"> At first it seems like a typo: request-rcticle.pl vs request-acticle.pl But actually it does not make sense to link to request-article, we want (I think) to link to the bibliographic record detail page. Test plan: - Have something in the claim table (cf bug 14697) - Click on the title of the bibliographic record Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 99806 [details] [review] Bug 24727: (bug 14697 follow-up) Replace link on title to bib detail page 903 let title = `<a class="return-claim-title strong" href="/cgi-bin/koha/circ/request-rcticle.pl?biblionumber=[% rc.checkout.item.biblionumber | html %]"> At first it seems like a typo: request-rcticle.pl vs request-acticle.pl But actually it does not make sense to link to request-article, we want (I think) to link to the bibliographic record detail page. Test plan: - Have something in the claim table (cf bug 14697) - Click on the title of the bibliographic record Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> We might want to change this one because of bug 24725! (In reply to Katrin Fischer from comment #11) > We might want to change this one because of bug 24725! ... and there already is a dependency. Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.x branch for 19.11.04 missing 19.05.x dependency, no backport |