| Summary: | Remove QueryParser-related code | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | 1joynelson, dcook, martin.renvoize, mtj |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 | ||
| Change sponsored?: | --- | Patch complexity: | Large patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | 9239, 12742 | ||
| Bug Blocks: | 20396, 25068, 28987 | ||
| Attachments: |
Bug 24735: Remove QueryParser-related code
Bug 24735: Remove QueryParser-related code Bug 24735: remove more code from tests Bug 24735: remove more code from tests Bug 24735: Remove QueryParser-related code Bug 24735: Remove more code from tests |
||
|
Description
Jonathan Druart
2020-02-26 12:33:52 UTC
Created attachment 99643 [details] [review] Bug 24735: Remove QueryParser-related code At the last development meeting we have voted to remove the QueryParser-related code https://wiki.koha-community.org/wiki/Development_IRC_meeting_19_February_2020 Hea tells us that it has not been adopted, and the code/bug tracker that it is not really usable as it. As nobody is willing to work on it, we decided to remove it instead. Test plan: % prove t/db_dependent/Search.t must return green See commits from bug 9239 and confirm that the code is removed in this patch. Also play with the search on the UI and confirm that you do not see obvious regressions Created attachment 99647 [details] [review] Bug 24735: Remove QueryParser-related code At the last development meeting we have voted to remove the QueryParser-related code https://wiki.koha-community.org/wiki/Development_IRC_meeting_19_February_2020 Hea tells us that it has not been adopted, and the code/bug tracker that it is not really usable as it. As nobody is willing to work on it, we decided to remove it instead. Test plan: % prove t/db_dependent/Search.t must return green See commits from bug 9239 and confirm that the code is removed in this patch. Also play with the search on the UI and confirm that you do not see obvious regressions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> No regressions found, used a few different customer derived zebra configs and datasets for testing. It's great to see how much code this removes reducing our technical debt significantly. Single followup inbound for a minor qa script failure ;) Thanks Jonathan, Signing off. On second thoughts.. not sure about the QA script error.. perlcritic t/db_dependent/Search.t Created attachment 99648 [details] [review] Bug 24735: remove more code from tests That was use by QP tests Created attachment 99649 [details] [review] Bug 24735: remove more code from tests That was use by QP tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Excellent, you did exactly what I came to the conclusion of too.. Signed off on followup. Hi Martin, I think we should still send the email to the mailingl ist as planned in the dev meeting before pushing this. Created attachment 99811 [details] [review] Bug 24735: Remove QueryParser-related code At the last development meeting we have voted to remove the QueryParser-related code https://wiki.koha-community.org/wiki/Development_IRC_meeting_19_February_2020 Hea tells us that it has not been adopted, and the code/bug tracker that it is not really usable as it. As nobody is willing to work on it, we decided to remove it instead. Test plan: % prove t/db_dependent/Search.t must return green See commits from bug 9239 and confirm that the code is removed in this patch. Also play with the search on the UI and confirm that you do not see obvious regressions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 99812 [details] [review] Bug 24735: Remove more code from tests That was use by QP tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> It's always sad to remove code that has taken a lot of work and thought to get in, but at this point in time, it seems the right thing to do. (In reply to Katrin Fischer from comment #11) > It's always sad to remove code that has taken a lot of work and thought to > get in, but at this point in time, it seems the right thing to do. I was thinking the same thing. Nice work everyone! Pushed to master for 20.05 Nice work everyone! Pushed to master for 20.05 does not apply to 19.11.x branch. please rebase if needed. I think this bug may have broken master package builds (despite what dashboard.koha-community.org is saying)? I'm getting the following error when building master packages and this seems like the only reason why it would happen... make[1]: Leaving directory '/home/koha/build/koha-19.12.00-test+20200518020508.3dc1f8a8' dh_install -O--fail-missing cp: cannot stat 'debian/tmp/debian/tmp/etc/koha/searchengine': No such file or directory dh_install: cp -a debian/tmp/debian/tmp/etc/koha/searchengine debian/koha-common//etc/koha/ returned exit code 1 debian/rules:9: recipe for target 'binary' failed make: *** [binary] Error 2 dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2 debuild: fatal error at line 1376: dpkg-buildpackage -rfakeroot -D -us -uc failed (In reply to David Cook from comment #16) > I think this bug may have broken master package builds (despite what > dashboard.koha-community.org is saying)? > Oh, it's already been reported as Bug 25068. Nevermind. |