Summary: | "Claim returned" feature cannot be turned off | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Circulation | Assignee: | Kyle M Hall (khall) <kyle> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | 1joynelson, gmcharlt, hc, jonathan.druart, kelly, kyle.m.hall, kyle, martin.renvoize, sally.healey |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.05
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 14697 | ||
Attachments: |
Bug 24767: "Claim returned" feature cannot be turned off
Bug 24767: "Claim returned" feature cannot be turned off Bug 24767: Hide the "Claim returned" tab if the feature is turned off |
Description
Katrin Fischer
2020-02-29 09:07:16 UTC
Can you be more specific? If the syspref ClaimReturnedLostValue is empty, the feature should be disabled. The ability to claim an item "claim returned" is not there if the syspref is empty, however, the Claim Returned tab is stil present on the patrons detail page. Created attachment 100618 [details] [review] Bug 24767: "Claim returned" feature cannot be turned off The ability to claim an item "claim returned" is not there if the syspref is empty, however, the Claim Returned tab is stil present on the patrons detail page. Test Plan: 1) Ensure ClaimReturnedLostValue is not set 2) Note the claims tabs on the circulation and patron details pages 3) Apply this patch 4) Refresh those pages 5) The claims tabs should be gone! Created attachment 100620 [details] [review] Bug 24767: "Claim returned" feature cannot be turned off The ability to claim an item "claim returned" is not there if the syspref is empty, however, the Claim Returned tab is stil present on the patrons detail page. Test Plan: 1) Ensure ClaimReturnedLostValue is not set 2) Note the claims tabs on the circulation and patron details pages 3) Apply this patch 4) Refresh those pages 5) The claims tabs should be gone! Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Created attachment 100640 [details] [review] Bug 24767: Hide the "Claim returned" tab if the feature is turned off The ability to claim an item "claim returned" is not there if the syspref is empty, however, the Claim Returned tab is stil present on the patrons detail page. Test Plan: 1) Ensure ClaimReturnedLostValue is not set 2) Note the claims tabs on the circulation and patron details pages 3) Apply this patch 4) Refresh those pages 5) The claims tabs should be gone! Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Commit title amended. Nice work everyone! Pushed to master for 20.05 Backported to 19.11.x branch for 19.11.05 |