Summary: | Payment submit button on POS page should have an ID | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
Component: | Fines and fees | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | 1joynelson, andrew, koha-bugs, mark.gavillet, martin.renvoize, sally.healey, testopia, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00
|
|
Circulation function: | |||
Bug Depends on: | 23354 | ||
Bug Blocks: | 13985 | ||
Attachments: |
Bug 24775: Add ID to POS submit payment button
Bug 24775: Add ID to POS submit payment button Bug 24775: Add ID to POS submit payment button Bug 24775: Add ID to POS submit payment button |
Description
Martin Renvoize (ashimema)
2020-03-02 11:55:41 UTC
Created attachment 99904 [details] [review] Bug 24775: Add ID to POS submit payment button This patch simply adds an ID to the submit button to make it easier to overide styling and functionality. Test Plan: 0/ Inspect the element on page and note there is no id 1/ Apply patch 2/ Refresh page 3/ Inspect the element on page and note there is now an id Created attachment 99954 [details] [review] Bug 24775: Add ID to POS submit payment button This patch simply adds an ID to the submit button to make it easier to overide styling and functionality. Test Plan: 0/ Inspect the element on page and note there is no id 1/ Apply patch 2/ Refresh page 3/ Inspect the element on page and note there is now an id Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Created attachment 99999 [details] [review] Bug 24775: Add ID to POS submit payment button This patch simply adds an ID to the submit button to make it easier to overide styling and functionality. Test Plan: 0/ Inspect the element on page and note there is no id 1/ Apply patch 2/ Refresh page 3/ Inspect the element on page and note there is now an id Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Created attachment 100098 [details] [review] Bug 24775: Add ID to POS submit payment button This patch simply adds an ID to the submit button to make it easier to overide styling and functionality. Test Plan: 0/ Inspect the element on page and note there is no id 1/ Apply patch 2/ Refresh page 3/ Inspect the element on page and note there is now an id Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Nice work everyone! Pushed to master for 20.05 not pushed to 19.11.x due to dependencies |