Sometimes people wish to override the payment button, for example to open a cash register via JS.. as such it's helpful to have an ID for the button.
Created attachment 99904 [details] [review] Bug 24775: Add ID to POS submit payment button This patch simply adds an ID to the submit button to make it easier to overide styling and functionality. Test Plan: 0/ Inspect the element on page and note there is no id 1/ Apply patch 2/ Refresh page 3/ Inspect the element on page and note there is now an id
Created attachment 99954 [details] [review] Bug 24775: Add ID to POS submit payment button This patch simply adds an ID to the submit button to make it easier to overide styling and functionality. Test Plan: 0/ Inspect the element on page and note there is no id 1/ Apply patch 2/ Refresh page 3/ Inspect the element on page and note there is now an id Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Created attachment 99999 [details] [review] Bug 24775: Add ID to POS submit payment button This patch simply adds an ID to the submit button to make it easier to overide styling and functionality. Test Plan: 0/ Inspect the element on page and note there is no id 1/ Apply patch 2/ Refresh page 3/ Inspect the element on page and note there is now an id Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Created attachment 100098 [details] [review] Bug 24775: Add ID to POS submit payment button This patch simply adds an ID to the submit button to make it easier to overide styling and functionality. Test Plan: 0/ Inspect the element on page and note there is no id 1/ Apply patch 2/ Refresh page 3/ Inspect the element on page and note there is now an id Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Nice work everyone! Pushed to master for 20.05
not pushed to 19.11.x due to dependencies