Bug 24776

Summary: Remove useless Borrowers Template Toolkit plugin
Product: Koha Reporter: Fridolin Somers <fridolin.somers>
Component: TemplatesAssignee: Fridolin Somers <fridolin.somers>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: 1joynelson, jonathan.druart, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24777
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
20.05.00
Attachments: Bug 24776: Remove Borrowers.HasOverdues call
Bug 24776: Remove Borrowers.IsDebarred call
Bug 24776: Remove file Koha/Template/Plugin/Borrowers.pm
Bug 24776: Remove Borrowers.HasOverdues call
Bug 24776: Remove Borrowers.IsDebarred call
Bug 24776: Remove file Koha/Template/Plugin/Borrowers.pm
Bug 24776: Remove Borrowers.HasOverdues call
Bug 24776: Remove Borrowers.IsDebarred call
Bug 24776: Remove file Koha/Template/Plugin/Borrowers.pm

Description Fridolin Somers 2020-03-02 14:16:55 UTC
Borrowers Template Toolkit plugin contains methods IsDebarred and HasOverdues that can be directly called from Koha::Patron object.
Also in template circ/returns.tt, when patron is restricted and checkin was backdated, var "patron" is undefined, should be "issue.patron".
Comment 1 Fridolin Somers 2020-03-02 14:39:04 UTC Comment hidden (obsolete)
Comment 2 Fridolin Somers 2020-03-02 14:39:22 UTC Comment hidden (obsolete)
Comment 3 Fridolin Somers 2020-03-02 14:43:12 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2020-03-09 18:04:33 UTC
Created attachment 100411 [details] [review]
Bug 24776: Remove Borrowers.HasOverdues call

Borrowers Template Toolkit plugin contains method HasOverdues that can be directly called from Koha::Patron object.

Test plan :
1) Go to circulation page of a patron with overdues
2) Click on print button
3) You see "Print overdues"
4) Go to circulation page of a patron without overdues
5) Click on print button
6) You don't see "Print overdues"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 5 Owen Leonard 2020-03-09 18:04:36 UTC
Created attachment 100412 [details] [review]
Bug 24776: Remove Borrowers.IsDebarred call

Borrowers Template Toolkit plugin contains method IsDebarred that can be directly called from Koha::Patron object.

Also in template circ/returns.tt, when patron is restricted and checkin was backdated, var "patron" is undefined, should be "issue.patron".

Test plan :
1) Enable system preference SpecifyReturnDate
2) For a patron without restriction create a checkout
3) Create a manual restriction to debarre patron
4) Go to return page and click on "Checkin settings"
5) Specify a date in the past, barcode and click "Check in"
6) You see message "Jon Doe is restricted. Please verify this patron should still be restricted."

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 6 Owen Leonard 2020-03-09 18:04:38 UTC
Created attachment 100413 [details] [review]
Bug 24776: Remove file Koha/Template/Plugin/Borrowers.pm

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 7 Jonathan Druart 2020-03-11 15:27:39 UTC
Created attachment 100580 [details] [review]
Bug 24776: Remove Borrowers.HasOverdues call

Borrowers Template Toolkit plugin contains method HasOverdues that can be directly called from Koha::Patron object.

Test plan :
1) Go to circulation page of a patron with overdues
2) Click on print button
3) You see "Print overdues"
4) Go to circulation page of a patron without overdues
5) Click on print button
6) You don't see "Print overdues"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Jonathan Druart 2020-03-11 15:27:42 UTC
Created attachment 100581 [details] [review]
Bug 24776: Remove Borrowers.IsDebarred call

Borrowers Template Toolkit plugin contains method IsDebarred that can be directly called from Koha::Patron object.

Also in template circ/returns.tt, when patron is restricted and checkin was backdated, var "patron" is undefined, should be "issue.patron".

Test plan :
1) Enable system preference SpecifyReturnDate
2) For a patron without restriction create a checkout
3) Create a manual restriction to debarre patron
4) Go to return page and click on "Checkin settings"
5) Specify a date in the past, barcode and click "Check in"
6) You see message "Jon Doe is restricted. Please verify this patron should still be restricted."

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 9 Jonathan Druart 2020-03-11 15:27:46 UTC
Created attachment 100582 [details] [review]
Bug 24776: Remove file Koha/Template/Plugin/Borrowers.pm

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 10 Martin Renvoize 2020-03-16 14:55:59 UTC
Nice work everyone!

Pushed to master for 20.05
Comment 11 Joy Nelson 2020-04-03 18:16:19 UTC
enhancement not backported to 19.11.x branch