| Summary: | Use patron.is_debarred instead of patron.debarred in return.tt | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
| Component: | Templates | Assignee: | Fridolin Somers <fridolin.somers> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | 1joynelson, lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.05
|
|
| Circulation function: | |||
| Attachments: |
Bug 24777: Use patron.is_debarred instead of patron.debarred in return.tt
Bug 24777: Use patron.is_debarred instead of patron.debarred in return.tt Bug 24777: Use patron.is_debarred instead of patron.debarred in return.tt |
||
|
Description
Fridolin Somers
2020-03-02 14:58:52 UTC
Created attachment 99926 [details] [review] Bug 24777: Use patron.is_debarred instead of patron.debarred in return.tt In return page return.tt, when there is an hold message, patron is said as restricted even if restriction end date is in the past. Test plan : 1) For a patron Jon Doe create a manual restriction with end date in the past 2) Create an hold for this patron on an item 3) Check in this item => You don't see message "Patron is RESTRICTED" 4) For a patron Kevin Doe create a manual restriction with end date in the future 5) Create an hold for this patron on an item 6) Check in this item => You see message "Patron is RESTRICTED" 7) Repeate 1-6 with system preference HoldsAutoFill enabled 8) Repeate 1-6 with a waiting hold Created attachment 100276 [details] [review] Bug 24777: Use patron.is_debarred instead of patron.debarred in return.tt In return page return.tt, when there is an hold message, patron is said as restricted even if restriction end date is in the past. Test plan : 1) For a patron Jon Doe create a manual restriction with end date in the past 2) Create an hold for this patron on an item 3) Check in this item => You don't see message "Patron is RESTRICTED" 4) For a patron Kevin Doe create a manual restriction with end date in the future 5) Create an hold for this patron on an item 6) Check in this item => You see message "Patron is RESTRICTED" 7) Repeate 1-6 with system preference HoldsAutoFill enabled 8) Repeate 1-6 with a waiting hold Signed-off-by: Devinim <nazli@devinim.com.tr> Created attachment 100457 [details] [review] Bug 24777: Use patron.is_debarred instead of patron.debarred in return.tt In return page return.tt, when there is an hold message, patron is said as restricted even if restriction end date is in the past. Test plan : 1) For a patron Jon Doe create a manual restriction with end date in the past 2) Create an hold for this patron on an item 3) Check in this item => You don't see message "Patron is RESTRICTED" 4) For a patron Kevin Doe create a manual restriction with end date in the future 5) Create an hold for this patron on an item 6) Check in this item => You see message "Patron is RESTRICTED" 7) Repeate 1-6 with system preference HoldsAutoFill enabled 8) Repeate 1-6 with a waiting hold Signed-off-by: Nazlı Çetin <nazli@devinim.com.tr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Nice work everyone! Pushed to master for 20.05 Backported to 19.11.x for 19.11.05 doesnt apply clean to 19.05.x, no backport |