| Summary: | HTML forms set a minimal width for dropdown combo with empty set | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Didier Gautheron <didier.gautheron> |
| Component: | Cataloging | Assignee: | Didier Gautheron <didier.gautheron> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | jonathan.druart, m.de.rooy, oleonard |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Crowdfunding committed: | 0 |
| Crowdfunding contact: | Patch complexity: | Trivial patch | |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 24814: HTML forms set a minimal width for dropdown combo with empty set.
Bug 24814: HTML forms set a minimal width for dropdown combo with empty set. |
||
|
Description
Didier Gautheron
2020-03-05 15:53:33 UTC
Created attachment 100202 [details] [review] Bug 24814: HTML forms set a minimal width for dropdown combo with empty set. If there's no item, dropdown message "No matches found" is hard to read. Affect: koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt To test: - Select a catalogue notice in Koha intranet. - Open add item form. - Choose a dropdown combo with an empty set, 'j - Shelving control number' is a good candidate. - Apply the patch. - Re select the compo in open add item form. Created attachment 100282 [details] [review] Bug 24814: HTML forms set a minimal width for dropdown combo with empty set. If there's no item, dropdown message "No matches found" is hard to read. Affect: koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt To test: - Select a catalogue notice in Koha intranet. - Open add item form. - Choose a dropdown combo with an empty set, 'j - Shelving control number' is a good candidate. - Apply the patch. - Re select the compo in open add item form. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Why 99? Should not this be a min-width CSS attribute instead? That would let us give a value in em. 99 is 100% arbitrary. Using min-width is another option, but I'm not sure it'd be smaller patch/cleaner though. I'll look at it. Moving to FQA for now, waiting for feedback from dev. Not anymore an issue with latest bootstrap |