Hi, If there's no item, dropdown message "No matches found" is hard to read. Affect: koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt To test: - Select a catalogue notice in Koha intranet. - Open add item form. - Choose a dropdown combo with an empty set, 'j - Shelving control number' is a good candidate. - Apply the patch. - Re select the compo in open add item form. It's a bandaid, a proper solution would be to compute container width on actuel message size.
Created attachment 100202 [details] [review] Bug 24814: HTML forms set a minimal width for dropdown combo with empty set. If there's no item, dropdown message "No matches found" is hard to read. Affect: koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt To test: - Select a catalogue notice in Koha intranet. - Open add item form. - Choose a dropdown combo with an empty set, 'j - Shelving control number' is a good candidate. - Apply the patch. - Re select the compo in open add item form.
Created attachment 100282 [details] [review] Bug 24814: HTML forms set a minimal width for dropdown combo with empty set. If there's no item, dropdown message "No matches found" is hard to read. Affect: koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt To test: - Select a catalogue notice in Koha intranet. - Open add item form. - Choose a dropdown combo with an empty set, 'j - Shelving control number' is a good candidate. - Apply the patch. - Re select the compo in open add item form. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Why 99? Should not this be a min-width CSS attribute instead? That would let us give a value in em.
99 is 100% arbitrary. Using min-width is another option, but I'm not sure it'd be smaller patch/cleaner though. I'll look at it.
Moving to FQA for now, waiting for feedback from dev.
Not anymore an issue with latest bootstrap