Bug 24814 - HTML forms set a minimal width for dropdown combo with empty set
Summary: HTML forms set a minimal width for dropdown combo with empty set
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Didier Gautheron
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-05 15:53 UTC by Didier Gautheron
Modified: 2022-06-06 20:25 UTC (History)
3 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Crowdfunding committed: 0
Crowdfunding contact:
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 24814: HTML forms set a minimal width for dropdown combo with empty set. (1.42 KB, patch)
2020-03-05 16:02 UTC, Didier Gautheron
Details | Diff | Splinter Review
Bug 24814: HTML forms set a minimal width for dropdown combo with empty set. (1.47 KB, patch)
2020-03-06 17:09 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Didier Gautheron 2020-03-05 15:53:33 UTC
Hi,

If there's no item, dropdown message "No matches found" is hard to read.

Affect:
koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt

To test:
- Select a catalogue notice in Koha intranet.
- Open add item form.
- Choose a dropdown combo with an empty set, 'j - Shelving control number' is a good candidate.
- Apply the patch.
- Re select the compo in open add item form.


It's a bandaid, a proper solution would be to compute container width on actuel message size.
Comment 1 Didier Gautheron 2020-03-05 16:02:35 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2020-03-06 17:09:22 UTC
Created attachment 100282 [details] [review]
Bug 24814: HTML forms set a minimal width for dropdown combo with empty set.

If there's no item, dropdown message "No matches found" is hard to read.

Affect:
koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt

To test:
- Select a catalogue notice in Koha intranet.
- Open add item form.
- Choose a dropdown combo with an empty set, 'j - Shelving control number' is a good candidate.
- Apply the patch.
- Re select the compo in open add item form.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Jonathan Druart 2020-03-12 15:11:13 UTC
Why 99?

Should not this be a min-width CSS attribute instead? That would let us give a value in em.
Comment 4 Didier Gautheron 2020-03-13 08:11:44 UTC
99 is 100% arbitrary.

Using min-width is another option, but I'm not sure it'd be smaller patch/cleaner though.

I'll look at it.
Comment 5 Katrin Fischer 2020-03-15 14:36:43 UTC
Moving to FQA for now, waiting for feedback from dev.
Comment 6 Didier Gautheron 2021-10-29 08:05:43 UTC
Not anymore an issue with latest bootstrap