Summary: | Refund modal confirm button should have an ID | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
Component: | Fines and fees | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | 1joynelson, andrew, koha-bugs, mark.gavillet, martin.renvoize, sally.healey, testopia, tomascohen |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24951 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
20.05.00
|
Circulation function: | |
Bug Depends on: | 23442 | ||
Bug Blocks: | 13985 | ||
Attachments: |
Bug 24952: Add id to refund modals confirm buttons
Bug 24952: Add id to refund modals confirm buttons Bug 24952: Add id to refund modals confirm buttons |
Description
Martin Renvoize (ashimema)
2020-03-23 12:15:48 UTC
Created attachment 101436 [details] [review] Bug 24952: Add id to refund modals confirm buttons This patch adds an ID to the refund confirmation modals for both borrower account and point of sale register details pages. Test plan: 1/ Apply patch 2/ Attempt to issue a refund to a patron 3/ Inspect the page and note the presence of an ID for the confirm button, 4/ Attempt to issue a refund via point of sale register details page 5/ Inspect the page and note the presence of an ID for the confirm button. 6/ Signoff Created attachment 101444 [details] [review] Bug 24952: Add id to refund modals confirm buttons This patch adds an ID to the refund confirmation modals for both borrower account and point of sale register details pages. Test plan: 1/ Apply patch 2/ Attempt to issue a refund to a patron 3/ Inspect the page and note the presence of an ID for the confirm button, 4/ Attempt to issue a refund via point of sale register details page 5/ Inspect the page and note the presence of an ID for the confirm button. 6/ Signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 101451 [details] [review] Bug 24952: Add id to refund modals confirm buttons This patch adds an ID to the refund confirmation modals for both borrower account and point of sale register details pages. Test plan: 1/ Apply patch 2/ Attempt to issue a refund to a patron 3/ Inspect the page and note the presence of an ID for the confirm button, 4/ Attempt to issue a refund via point of sale register details page 5/ Inspect the page and note the presence of an ID for the confirm button. 6/ Signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Nice work everyone! Pushed to master for 20.05 enhancement not backported to 19.11.x |