| Summary: | Improve display of Production credits (MARC21 508) in OPAC and staff | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | MARC Bibliographic data support | Assignee: | Katrin Fischer <katrin.fischer> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | 1joynelson, david, m.de.rooy, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This change makes some tiny changes to improve the display and consistency between the OPAC and staff interface:
- Capitalization: Production Credits --> Production credits.
- Change div to span to avoid display issues.
- Make sequence of fields in display match (505, 508, 586).
|
Version(s) released in: |
20.05.00
|
| Circulation function: | |||
| Bug Depends on: | 13385 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 25011: Add MARC21 508 - Production credits to staff detail page
Bug 25011: Improve display of MARC21 508 - Production credits in staff and OPAC Bug 25011: Improve display of MARC21 508 - Production credits in staff and OPAC Bug 25011: Improve display of MARC21 508 - Production credits in staff and OPAC |
||
|
Description
Katrin Fischer
2020-03-27 22:46:31 UTC
Created attachment 102022 [details] [review] Bug 25011: Add MARC21 508 - Production credits to staff detail page Bug 13385 added 508 to the OPAC detail page, but missed the staff side. This patch makes the display consistent again between staff and OPAC. Additional changes: - Capitalization fix: Production Credits - Production credits - Changes div to span avoiding display issues To test: - Catalog one or more records with none, one and multiple 508 $a - Check and compare the staff and OPAC detail pages, both should display the production credits information now correctly Someone must have already fixed staff side since I put this on my todo list (ages ago). Fixing my patch :) Created attachment 102024 [details] [review] Bug 25011: Improve display of MARC21 508 - Production credits in staff and OPAC Makes some tiny changes to improve display and consistency between OPAC and staff: - Capitalization fix: Production Credits - Production credits - Changes div to span avoiding display issues - Make sequence of fields in display match (505, 508, 586) To test: - Catalog one or more records with none, one and multiple 508 $a - Check and compare the staff and OPAC detail pages, both should display the production credits information correctly Hi Katrin. In the staff interface 508 is already included, so when the patch is applied it displays twice (around line 1026 in the patch file, after the 586 field). The patch does fix the display of 508 in the OPAC. One thing I noticed is that the 'Contents' heading for 505 displays in the OPAC, but doesn't in the staff interface (this is the case before and after the patch is applied). David Hi David, sorry, I had realized my mistake but missed to obsolete the first patch. The patch attached now should be ok. Please file a bug for 505 - happy to have a look. Created attachment 102059 [details] [review] Bug 25011: Improve display of MARC21 508 - Production credits in staff and OPAC Makes some tiny changes to improve display and consistency between OPAC and staff: - Capitalization fix: Production Credits - Production credits - Changes div to span avoiding display issues - Make sequence of fields in display match (505, 508, 586) To test: - Catalog one or more records with none, one and multiple 508 $a - Check and compare the staff and OPAC detail pages, both should display the production credits information correctly Signed-off-by: David Nind <david@davidnind.com> (In reply to Katrin Fischer from comment #5) > Hi David, sorry, I had realized my mistake but missed to obsolete the first > patch. The patch attached now should be ok. Please file a bug for 505 - > happy to have a look. No problem! The contents is now displaying correctly in the staff interface, so I'll pu that down to me! David Created attachment 103119 [details] [review] Bug 25011: Improve display of MARC21 508 - Production credits in staff and OPAC Makes some tiny changes to improve display and consistency between OPAC and staff: - Capitalization fix: Production Credits - Production credits - Changes div to span avoiding display issues - Make sequence of fields in display match (505, 508, 586) To test: - Catalog one or more records with none, one and multiple 508 $a - Check and compare the staff and OPAC detail pages, both should display the production credits information correctly Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Nice work everyone! Pushed to master for 20.05 enhancement not backported to 19.11.x |