Summary: | Staff with 'Edit Iitems' permission currently can not edit Items attached to a fast add framework | ||
---|---|---|---|
Product: | Koha | Reporter: | Kelly McElligott <kelly> |
Component: | Cataloging | Assignee: | Emily Lamancusa (emlam) <emily.lamancusa> |
Status: | Pushed to main --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | minor | ||
Priority: | P5 - low | CC: | andrew, angela.berrett, chris.rowlands6, echandler, emily.lamancusa, m.de.rooy, phil |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
25.05.00
|
Circulation function: | |
Attachments: |
Bug 25015: Allow staff with edit_items permissions to edit fast add items
Bug 25015: Allow staff with edit_items permissions to edit fast add items Bug 25015: Allow staff with edit_items permissions to edit fast add items Bug 25015: Allow staff with edit_items permissions to edit fast add items Bug 25015: (QA follow-up) Slide together |
Description
Kelly McElligott
2020-03-28 12:03:09 UTC
Working with a specific library that stumbled upon this bug, they feel that the staff member with edit Items permission should be able to edit any items. Still true on master as of 7/2/21. This is not correct. Someone with Edit Items should be able to edit items on a Fast Add bib regardless of whether or not they have fast_cataloging permission. This has cropped up for us recently as well. I think our libraries were also expecting that edit_items wouldn't be blocked by an unchecked fast_cataloguing permission. However, you can still edit these blocked items if you use the batch modification feature on the record. Created attachment 179611 [details] [review] Bug 25015: Allow staff with edit_items permissions to edit fast add items To test: 1. Set up a user with only catalogue and add_items permissions 2. Create a Fast Add record with item a. Go to Cataloging b. Click on Fast Cataloging c. Fill in mandatory fields and save the record d. Fill in mandatory item fields and click Add item 3. Log in as the user you set up in step 1 4. Search for the record you created in step 2 5. Click Edit > Manage items in the menu at the top of the record ==> You do not have permission to access this page! 6. Go back to biblio record page 7. Apply patch and restart_all 8. Click Edit > Manage items again ==> Edit items page loads normally 9. Make a few edits and confirm that they save correctly Created attachment 179612 [details] [review] Bug 25015: Allow staff with edit_items permissions to edit fast add items To test: 1. Set up a user with only catalogue and edit_items permissions 2. Create a Fast Add record with item a. Go to Cataloging b. Click on Fast Cataloging c. Fill in mandatory fields and save the record d. Fill in mandatory item fields and click Add item 3. Log in as the user you set up in step 1 4. Search for the record you created in step 2 5. Click Edit > Manage items in the menu at the top of the record ==> You do not have permission to access this page! 6. Go back to biblio record page 7. Apply patch and restart_all 8. Click Edit > Manage items again ==> Edit items page loads normally 9. Make a few edits and confirm that they save correctly Created attachment 179896 [details] [review] Bug 25015: Allow staff with edit_items permissions to edit fast add items To test: 1. Set up a user with only catalogue and edit_items permissions 2. Create a Fast Add record with item a. Go to Cataloging b. Click on Fast Cataloging c. Fill in mandatory fields and save the record d. Fill in mandatory item fields and click Add item 3. Log in as the user you set up in step 1 4. Search for the record you created in step 2 5. Click Edit > Manage items in the menu at the top of the record ==> You do not have permission to access this page! 6. Go back to biblio record page 7. Apply patch and restart_all 8. Click Edit > Manage items again ==> Edit items page loads normally 9. Make a few edits and confirm that they save correctly Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Created attachment 181152 [details] [review] Bug 25015: Allow staff with edit_items permissions to edit fast add items To test: 1. Set up a user with only catalogue and edit_items permissions 2. Create a Fast Add record with item a. Go to Cataloging b. Click on Fast Cataloging c. Fill in mandatory fields and save the record d. Fill in mandatory item fields and click Add item 3. Log in as the user you set up in step 1 4. Search for the record you created in step 2 5. Click Edit > Manage items in the menu at the top of the record ==> You do not have permission to access this page! 6. Go back to biblio record page 7. Apply patch and restart_all 8. Click Edit > Manage items again ==> Edit items page loads normally 9. Make a few edits and confirm that they save correctly Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Created attachment 181153 [details] [review] Bug 25015: (QA follow-up) Slide together We do not need 1 or 0 here btw. We just check for true. Marcel, added your missing sign-off line to the first patch. Pushed for 25.05! Well done everyone, thank you! |