Bug 25015 - Staff with 'Edit Iitems' permission currently can not edit Items attached to a fast add framework
Summary: Staff with 'Edit Iitems' permission currently can not edit Items attached to ...
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Emily Lamancusa (emlam)
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-28 12:03 UTC by Kelly McElligott
Modified: 2025-04-22 06:49 UTC (History)
7 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 25015: Allow staff with edit_items permissions to edit fast add items (2.36 KB, patch)
2025-03-21 13:58 UTC, Emily Lamancusa (emlam)
Details | Diff | Splinter Review
Bug 25015: Allow staff with edit_items permissions to edit fast add items (2.36 KB, patch)
2025-03-21 14:00 UTC, Emily Lamancusa (emlam)
Details | Diff | Splinter Review
Bug 25015: Allow staff with edit_items permissions to edit fast add items (2.42 KB, patch)
2025-03-28 23:13 UTC, Phil Ringnalda
Details | Diff | Splinter Review
Bug 25015: Allow staff with edit_items permissions to edit fast add items (2.46 KB, patch)
2025-04-18 08:02 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 25015: (QA follow-up) Slide together (1.27 KB, patch)
2025-04-18 08:02 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kelly McElligott 2020-03-28 12:03:09 UTC
If a staff has the permission has only the permission in Cataloging to "Edit Items" currently, they can't edit items attached to a Fast Add bib.  

What should the change be?  

Does a staff member need to have Fast Cataloging and Edit Items to be able to Edit Items attached to a Fast Added Bib?  And if that is the case, the bug lies with the fact the staff member doesn't know that this bib is a Fast Add bib-  the Edit option should not be visible to staff that only have "edit items" and not "Fast Cataloging"


Or 

Is it a library's understanding that the permission "Edit Items" allows All Items can be edited even the items attached to Fast Add Biblios? And if that is the case, then the change lies with how the permissions are coded in Koha.
Comment 1 Kelly McElligott 2020-03-30 14:47:08 UTC
Working with a specific library that stumbled upon this bug, they feel that the staff member with edit Items permission should be able to edit any items.
Comment 2 Andrew Fuerste-Henry 2021-07-02 14:45:50 UTC
Still true on master as of 7/2/21. This is not correct. Someone with Edit Items should be able to edit items on a Fast Add bib regardless of whether or not they have fast_cataloging permission.
Comment 3 Chris Rowlands 2023-12-06 10:19:43 UTC
This has cropped up for us recently as well. I think our libraries were also expecting that edit_items wouldn't be blocked by an unchecked fast_cataloguing permission.

However, you can still edit these blocked items if you use the batch modification feature on the record.
Comment 4 Emily Lamancusa (emlam) 2025-03-21 13:58:27 UTC Comment hidden (obsolete)
Comment 5 Emily Lamancusa (emlam) 2025-03-21 14:00:14 UTC
Created attachment 179612 [details] [review]
Bug 25015: Allow staff with edit_items permissions to edit fast add items

To test:
1. Set up a user with only catalogue and edit_items permissions
2. Create a Fast Add record with item
    a. Go to Cataloging
    b. Click on Fast Cataloging
    c. Fill in mandatory fields and save the record
    d. Fill in mandatory item fields and click Add item
3. Log in as the user you set up in step 1
4. Search for the record you created in step 2
5. Click Edit > Manage items in the menu at the top of the record
==> You do not have permission to access this page!
6. Go back to biblio record page
7. Apply patch and restart_all
8. Click Edit > Manage items again
==> Edit items page loads normally
9. Make a few edits and confirm that they save correctly
Comment 6 Phil Ringnalda 2025-03-28 23:13:22 UTC
Created attachment 179896 [details] [review]
Bug 25015: Allow staff with edit_items permissions to edit fast add items

To test:
1. Set up a user with only catalogue and edit_items permissions
2. Create a Fast Add record with item
    a. Go to Cataloging
    b. Click on Fast Cataloging
    c. Fill in mandatory fields and save the record
    d. Fill in mandatory item fields and click Add item
3. Log in as the user you set up in step 1
4. Search for the record you created in step 2
5. Click Edit > Manage items in the menu at the top of the record
==> You do not have permission to access this page!
6. Go back to biblio record page
7. Apply patch and restart_all
8. Click Edit > Manage items again
==> Edit items page loads normally
9. Make a few edits and confirm that they save correctly

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 7 Marcel de Rooy 2025-04-18 08:02:30 UTC
Created attachment 181152 [details] [review]
Bug 25015: Allow staff with edit_items permissions to edit fast add items

To test:
1. Set up a user with only catalogue and edit_items permissions
2. Create a Fast Add record with item
    a. Go to Cataloging
    b. Click on Fast Cataloging
    c. Fill in mandatory fields and save the record
    d. Fill in mandatory item fields and click Add item
3. Log in as the user you set up in step 1
4. Search for the record you created in step 2
5. Click Edit > Manage items in the menu at the top of the record
==> You do not have permission to access this page!
6. Go back to biblio record page
7. Apply patch and restart_all
8. Click Edit > Manage items again
==> Edit items page loads normally
9. Make a few edits and confirm that they save correctly

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 8 Marcel de Rooy 2025-04-18 08:02:33 UTC
Created attachment 181153 [details] [review]
Bug 25015: (QA follow-up) Slide together

We do not need 1 or 0 here btw. We just check for true.
Comment 9 Katrin Fischer 2025-04-22 06:41:07 UTC
Marcel, added your missing sign-off line to the first patch.
Comment 10 Katrin Fischer 2025-04-22 06:49:24 UTC
Pushed for 25.05!

Well done everyone, thank you!