If a staff has the permission has only the permission in Cataloging to "Edit Items" currently, they can't edit items attached to a Fast Add bib. What should the change be? Does a staff member need to have Fast Cataloging and Edit Items to be able to Edit Items attached to a Fast Added Bib? And if that is the case, the bug lies with the fact the staff member doesn't know that this bib is a Fast Add bib- the Edit option should not be visible to staff that only have "edit items" and not "Fast Cataloging" Or Is it a library's understanding that the permission "Edit Items" allows All Items can be edited even the items attached to Fast Add Biblios? And if that is the case, then the change lies with how the permissions are coded in Koha.
Working with a specific library that stumbled upon this bug, they feel that the staff member with edit Items permission should be able to edit any items.
Still true on master as of 7/2/21. This is not correct. Someone with Edit Items should be able to edit items on a Fast Add bib regardless of whether or not they have fast_cataloging permission.
This has cropped up for us recently as well. I think our libraries were also expecting that edit_items wouldn't be blocked by an unchecked fast_cataloguing permission. However, you can still edit these blocked items if you use the batch modification feature on the record.
Created attachment 179611 [details] [review] Bug 25015: Allow staff with edit_items permissions to edit fast add items To test: 1. Set up a user with only catalogue and add_items permissions 2. Create a Fast Add record with item a. Go to Cataloging b. Click on Fast Cataloging c. Fill in mandatory fields and save the record d. Fill in mandatory item fields and click Add item 3. Log in as the user you set up in step 1 4. Search for the record you created in step 2 5. Click Edit > Manage items in the menu at the top of the record ==> You do not have permission to access this page! 6. Go back to biblio record page 7. Apply patch and restart_all 8. Click Edit > Manage items again ==> Edit items page loads normally 9. Make a few edits and confirm that they save correctly
Created attachment 179612 [details] [review] Bug 25015: Allow staff with edit_items permissions to edit fast add items To test: 1. Set up a user with only catalogue and edit_items permissions 2. Create a Fast Add record with item a. Go to Cataloging b. Click on Fast Cataloging c. Fill in mandatory fields and save the record d. Fill in mandatory item fields and click Add item 3. Log in as the user you set up in step 1 4. Search for the record you created in step 2 5. Click Edit > Manage items in the menu at the top of the record ==> You do not have permission to access this page! 6. Go back to biblio record page 7. Apply patch and restart_all 8. Click Edit > Manage items again ==> Edit items page loads normally 9. Make a few edits and confirm that they save correctly
Created attachment 179896 [details] [review] Bug 25015: Allow staff with edit_items permissions to edit fast add items To test: 1. Set up a user with only catalogue and edit_items permissions 2. Create a Fast Add record with item a. Go to Cataloging b. Click on Fast Cataloging c. Fill in mandatory fields and save the record d. Fill in mandatory item fields and click Add item 3. Log in as the user you set up in step 1 4. Search for the record you created in step 2 5. Click Edit > Manage items in the menu at the top of the record ==> You do not have permission to access this page! 6. Go back to biblio record page 7. Apply patch and restart_all 8. Click Edit > Manage items again ==> Edit items page loads normally 9. Make a few edits and confirm that they save correctly Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>