Bug 25104

Summary: Small adjustments in NewVersion
Product: Koha Reporter: Marcel de Rooy <m.de.rooy>
Component: Architecture, internals, and plumbingAssignee: Marcel de Rooy <m.de.rooy>
Status: CLOSED WONTFIX QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: jonathan.druart, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 24131    
Bug Blocks:    
Attachments: Bug 25104: Small adjustments to NewVersion

Description Marcel de Rooy 2020-04-10 07:47:33 UTC

    
Comment 1 Marcel de Rooy 2020-04-10 07:59:45 UTC
Created attachment 102677 [details] [review]
Bug 25104: Small adjustments to NewVersion

Main point: all descriptions go under the line with version/bugno.
Simplify the code in NewVersion.

Test plan:
Run updatedatabase on command line as well as interface.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Jonathan Druart 2020-04-14 10:18:14 UTC
The idea was to keep 1 line per entry, so I do not think we should split them into 2.
Also I liked the idea of not having to pass an arrayref when we have only 1 line (90% of the time).
Comment 3 Martin Renvoize 2020-04-14 10:45:54 UTC
I agree with Jonathan here, keeping comments on one line where we can is a feature rather than a bug.. The code may be a little messy, but it's also clear what it does.

What I would like to see at some point is more of a guideline for how to best use the multi-line descriptions.. I think in general we should lead with a short summary and following lines should be for either deeper descriptions or warnings..