Bug 25104 - Small adjustments in NewVersion
Summary: Small adjustments in NewVersion
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on: 24131
Blocks:
  Show dependency treegraph
 
Reported: 2020-04-10 07:47 UTC by Marcel de Rooy
Modified: 2020-11-30 21:45 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 25104: Small adjustments to NewVersion (3.44 KB, patch)
2020-04-10 07:59 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2020-04-10 07:47:33 UTC

    
Comment 1 Marcel de Rooy 2020-04-10 07:59:45 UTC
Created attachment 102677 [details] [review]
Bug 25104: Small adjustments to NewVersion

Main point: all descriptions go under the line with version/bugno.
Simplify the code in NewVersion.

Test plan:
Run updatedatabase on command line as well as interface.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Jonathan Druart 2020-04-14 10:18:14 UTC
The idea was to keep 1 line per entry, so I do not think we should split them into 2.
Also I liked the idea of not having to pass an arrayref when we have only 1 line (90% of the time).
Comment 3 Martin Renvoize 2020-04-14 10:45:54 UTC
I agree with Jonathan here, keeping comments on one line where we can is a feature rather than a bug.. The code may be a little messy, but it's also clear what it does.

What I would like to see at some point is more of a guideline for how to best use the multi-line descriptions.. I think in general we should lead with a short summary and following lines should be for either deeper descriptions or warnings..