Summary: | PatronSelfRegistrationLibraryList controls both self-reg and self-modification | ||
---|---|---|---|
Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
Component: | OPAC | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | 1joynelson, lucas |
Version: | 19.05 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00
|
|
Circulation function: | |||
Bug Depends on: | 25137 | ||
Bug Blocks: | |||
Attachments: |
Bug 25136: Make PatronSelfRegistrationLibraryList only effect new registration
Bug 25136: Make PatronSelfRegistrationLibraryList only effect new registration Bug 25136: Make PatronSelfRegistrationLibraryList only effect new registration Bug 25136: join the 2 ifs |
Description
Andrew Fuerste-Henry
2020-04-13 19:43:46 UTC
Bug around this syspref in master: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25137 Created attachment 103042 [details] [review] Bug 25136: Make PatronSelfRegistrationLibraryList only effect new registration This patch makes it so PatronSelfRegistrationLibraryList will only effect the registration from and not the modification form. TO TEST: 1. Turn on self reg and add some libaries to PatronSelfRegistrationLibraryList. 2. Notice that the libaries that display in the borrower_branchcode dropdown are the ones you selected on both the new registration from and the modification form. 3. Apply patch. 4. Now only the new registration from should show libaries on PatronSelfRegistrationLibraryList. 5. The modifciation dropdown should still show all libraries. Created attachment 103056 [details] [review] Bug 25136: Make PatronSelfRegistrationLibraryList only effect new registration This patch makes it so PatronSelfRegistrationLibraryList will only effect the registration from and not the modification form. TO TEST: 1. Turn on self reg and add some libaries to PatronSelfRegistrationLibraryList. 2. Notice that the libaries that display in the borrower_branchcode dropdown are the ones you selected on both the new registration from and the modification form. 3. Apply patch. 4. Now only the new registration from should show libaries on PatronSelfRegistrationLibraryList. 5. The modifciation dropdown should still show all libraries. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Created attachment 103066 [details] [review] Bug 25136: Make PatronSelfRegistrationLibraryList only effect new registration This patch makes it so PatronSelfRegistrationLibraryList will only effect the registration from and not the modification form. TO TEST: 1. Turn on self reg and add some libaries to PatronSelfRegistrationLibraryList. 2. Notice that the libaries that display in the borrower_branchcode dropdown are the ones you selected on both the new registration from and the modification form. 3. Apply patch. 4. Now only the new registration from should show libaries on PatronSelfRegistrationLibraryList. 5. The modifciation dropdown should still show all libraries. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 103067 [details] [review] Bug 25136: join the 2 ifs Highlight that we only need this for action="new" Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Nice work everyone! Pushed to master for 20.05 missing dependencies - not backported to 19.11.x |