Bug 13188 - Make it possible to configure mandatory patron data differently between OPAC registration and modification
Summary: Make it possible to configure mandatory patron data differently between OPAC ...
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Lucas Gass
QA Contact: Testopia
URL:
Keywords:
: 24174 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-11-03 14:49 UTC by Fridolin Somers
Modified: 2021-02-04 14:42 UTC (History)
11 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13188: Add PatronSelfModificationMandatoryField system preference (4.36 KB, patch)
2021-01-19 22:42 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 13188: Add PatronSelfModificationMandatoryField system preference (5.42 KB, patch)
2021-01-19 22:44 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 13188: Add PatronSelfModificationMandatoryField system preference (5.16 KB, patch)
2021-01-29 23:45 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2014-11-03 14:49:11 UTC
For an registered patron, the page /cgi-bin/koha/opac-memberentry.pl displays his personal details and allow him to ask for a change.
In this page mandatory fields are wrong. It uses PatronSelfRegistrationBorrowerMandatoryField instead of BorrowerMandatoryField.
Comment 1 Katrin Fischer 2014-11-03 21:39:06 UTC
I am not sure if it's wrong - it seems like it might be intended behaviour. The library staff might have a different set of fields to fill out then the patron.
I am not sure, but i think it earlier versions we didn't check for mandatory fields at all.
Comment 2 Fridolin Somers 2014-11-04 17:11:02 UTC
(In reply to Katrin Fischer from comment #1)
> I am not sure if it's wrong - it seems like it might be intended behaviour.
> The library staff might have a different set of fields to fill out then the
> patron.
> I am not sure, but i think it earlier versions we didn't check for mandatory
> fields at all.

Indeed, but in case the preference PatronSelfRegistration is off, one should not have to configure the preference PatronSelfRegistrationBorrowerMandatoryField.
For me this preference only applies to the self-registration form.
Comment 3 Ola Andersson 2017-11-03 20:40:55 UTC
It is not possible with Koha 17.05.05 to configure a set of mandatory fields in SelfRegistration and at the same time configure another set of mandatory fields in SelfModification. This seems to be a design flaw.

E.g. we would like to have Address2 field mandatory in SelfRegistration but optional in SelfModification.
Comment 4 Katrin Fischer 2017-11-16 00:03:28 UTC
Hi Ola, have you seen PatronSelfModificationBorrowerUnwantedField?

I think this bug might be resolved with the newer preference.
Comment 5 Ola Andersson 2017-11-16 07:33:47 UTC
Hi Katrin! Yes I have seen PatronSelfModificationBorrowerUnwantedField. The problem is if you like us would like to keep Address2 field in both SelfRegistration and SelfModification but have it as an optional fields in SelfModification and a compulsory field in SelfRegistration. This configuration seems impossible with Koha settings.
Comment 6 Katrin Fischer 2017-12-05 06:46:20 UTC
Ah, I think I got it now. So we should differentiate between modification and registration for the mandatory fields as well:

PatronSelfRegistrationBorrowerUnwantedField
PatronSelfModificationBorrowerUnwantedField

PatronSelfRegistrationBorrowerMandatoryField
TODO: PatronSelfModificationBorrowerMandatoryField

Just wondering: why ask for it as mandatory on registration when it is not needed later on?
Comment 7 Ola Andersson 2017-12-05 09:33:14 UTC
Hi Katrin!

We would like to enable self registration to our employees only and they are required to enter their department in Address field 2.

However in the OPAC we have enabled self modification for all patrons and here address field 2 can be empty for patrons such as students.
Comment 8 Katrin Fischer 2017-12-05 10:29:49 UTC
Hi Ola, thx for explaining the use case!
Comment 9 Brian 2019-04-16 22:12:39 UTC
Any updates on bug 13188?

Carnegie team.
Comment 10 Magnus Enger 2019-06-12 08:25:32 UTC
A more or less related problem: If you set password as mandatory in PatronSelfRegistrationBorrowerMandatoryField it does not show up in the edit form (there is a separate screen for changing the password), and the edit form can never be submitted successfully. 

With a new syspref PatronSelfModificationBorrowerMandatoryField it would be possible to set it as not mandatory in the edit screen.
Comment 11 Séverine Queune 2019-10-28 10:57:11 UTC
(In reply to Magnus Enger from comment #10)
> A more or less related problem: If you set password as mandatory in
> PatronSelfRegistrationBorrowerMandatoryField it does not show up in the edit
> form (there is a separate screen for changing the password), and the edit
> form can never be submitted successfully. 
> 
> With a new syspref PatronSelfModificationBorrowerMandatoryField it would be
> possible to set it as not mandatory in the edit screen.

This peculiar problem with password field is very annoying (at BULAC, we experience it since we update in 18.05, was working on 16.11), shouldn't we open a new ticket to solve this specific point, if no one can work the new syspref ?
Comment 12 Katrin Fischer 2019-12-22 14:27:27 UTC
*** Bug 24174 has been marked as a duplicate of this bug. ***
Comment 13 Fridolin Somers 2020-11-16 14:28:11 UTC
PatronSelfModificationBorrowerMandatoryField looks as a strange name to me.

Maybe OpacBorrowerMandatoryField ?
Comment 14 Christopher Brannon 2020-11-16 15:44:48 UTC
(In reply to Fridolin Somers from comment #13)
> PatronSelfModificationBorrowerMandatoryField looks as a strange name to me.
> 
> Maybe OpacBorrowerMandatoryField ?

+1
Comment 15 Christopher Brannon 2020-11-16 15:45:04 UTC
(In reply to Fridolin Somers from comment #13)
> PatronSelfModificationBorrowerMandatoryField looks as a strange name to me.
> 
> Maybe OpacBorrowerMandatoryField ?

+1
Comment 16 Lucas Gass 2021-01-19 22:42:24 UTC Comment hidden (obsolete)
Comment 17 Lucas Gass 2021-01-19 22:44:53 UTC Comment hidden (obsolete)
Comment 18 Lucas Gass 2021-01-29 23:45:52 UTC
Created attachment 116085 [details] [review]
Bug 13188: Add PatronSelfModificationMandatoryField system preference

TEST PLAN:
1. Apply patch, updatedatabase, restart_all
2. In the  PatronSelfRegistrationBorrowerMandatoryField add the field password.
3. Go to the self registration page on make sure password is required.
4. Now go to the OPAC modification page, make some changes and attempt to submit. It should work.
5. Go to PatronSelfModificationMandatoryField and select some fields.
6. The columns you selected should now be required.
7. On the PatronSelfModificationMandatoryField page, make sure the select all and clear all buttons work.