Summary: | Lots of white space at the bottom of each tab on columns configuration | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Templates | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Josef Moravec <josef.moravec> |
Severity: | minor | ||
Priority: | P5 - low | CC: | 1joynelson, gmcharlt, jonathan.druart, josef.moravec, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.06, 19.05.11
|
|
Circulation function: | |||
Bug Depends on: | 10212 | ||
Bug Blocks: | |||
Attachments: |
Bug 25186: Fix accordion sections height in columns configuration page
Bug 25186: Fix accordion sections height in columns configuration page Bug 25186: Fix accordion sections height in columns configuration page |
Description
Katrin Fischer
2020-04-18 02:44:54 UTC
Created attachment 103237 [details] [review] Bug 25186: Fix accordion sections height in columns configuration page The height for each section was the height of the highest section. Now the height is set to the length of the section. Test plan: Go to Administration > Column configuration Open the sections and confirm that the height fits its content. QA: note that I guess "autoHeight: false" was meant to acchieve that, but it does not exist in the API of the plugin. Created attachment 103279 [details] [review] Bug 25186: Fix accordion sections height in columns configuration page The height for each section was the height of the highest section. Now the height is set to the length of the section. Test plan: Go to Administration > Column configuration Open the sections and confirm that the height fits its content. QA: note that I guess "autoHeight: false" was meant to acchieve that, but it does not exist in the API of the plugin. Signed-off-by: Owen Leonard <oleonard@myacpl.org> (In reply to Owen Leonard from comment #2) > QA: note that I guess "autoHeight: false" was meant to acchieve that, > but it does not exist in the API of the plugin. That's right. "autoHeight: false" was the option in jQueryUI version 1.8 and lower and didn't get updated when we upgraded to 1.11. Created attachment 103390 [details] [review] Bug 25186: Fix accordion sections height in columns configuration page The height for each section was the height of the highest section. Now the height is set to the length of the section. Test plan: Go to Administration > Column configuration Open the sections and confirm that the height fits its content. QA: note that I guess "autoHeight: false" was meant to acchieve that, but it does not exist in the API of the plugin. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Nice work everyone! Pushed to master for 20.05 backported to 19.11.x for 19.11.06 backported to 19.05.x for 19.05.11 |