When looking at the different tabs for Administration > Column configuration, there is a lot of white space to scroll through after the listed tables on each tab. This makes it harder to use, as you have to scroll over this to switch to any tab below your currently selected (accordeon view), so I think we could treat it as a 'small bug'.
Created attachment 103237 [details] [review] Bug 25186: Fix accordion sections height in columns configuration page The height for each section was the height of the highest section. Now the height is set to the length of the section. Test plan: Go to Administration > Column configuration Open the sections and confirm that the height fits its content. QA: note that I guess "autoHeight: false" was meant to acchieve that, but it does not exist in the API of the plugin.
Created attachment 103279 [details] [review] Bug 25186: Fix accordion sections height in columns configuration page The height for each section was the height of the highest section. Now the height is set to the length of the section. Test plan: Go to Administration > Column configuration Open the sections and confirm that the height fits its content. QA: note that I guess "autoHeight: false" was meant to acchieve that, but it does not exist in the API of the plugin. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
(In reply to Owen Leonard from comment #2) > QA: note that I guess "autoHeight: false" was meant to acchieve that, > but it does not exist in the API of the plugin. That's right. "autoHeight: false" was the option in jQueryUI version 1.8 and lower and didn't get updated when we upgraded to 1.11.
Created attachment 103390 [details] [review] Bug 25186: Fix accordion sections height in columns configuration page The height for each section was the height of the highest section. Now the height is set to the length of the section. Test plan: Go to Administration > Column configuration Open the sections and confirm that the height fits its content. QA: note that I guess "autoHeight: false" was meant to acchieve that, but it does not exist in the API of the plugin. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Nice work everyone! Pushed to master for 20.05
backported to 19.11.x for 19.11.06
backported to 19.05.x for 19.05.11