| Summary: | Correct hover style of list share button in the OPAC | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | 1joynelson, lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25211 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.06
|
|
| Circulation function: | |||
| Bug Depends on: | 25211 | ||
| Bug Blocks: | 25280 | ||
| Attachments: |
Bug 25276: Correct hover style of list share button in the OPAC
Bug 25276: Correct hover style of list share button in the OPAC Bug 25276: Correct hover style of list share button in the OPAC |
||
|
Description
Owen Leonard
2020-04-24 13:04:09 UTC
Created attachment 103692 [details] [review] Bug 25276: Correct hover style of list share button in the OPAC This patch adds missing "btn" classes to the OPAC share button so that its style is consistent with similar controls. The patch also makes some general changes to the OPAC CSS to make sure link color and hover color are applied with enough specificity. This corrects the hover color of the share button but should not change any other existing style. To test you should have the OpacAllowSharingPrivateLists preference enabled. - Rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Log in to the OPAC as a user with one or more private lists. - Go to Lists -> Your lists. - In the list of lists there should be a "Share" link for each list. Hovering your mouse pointer over the link should change the style in the same way the "Edit" link does. Owen, I cannot cleanly apply this patch to master: error: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt). error: could not build fake ancestor Patch failed at 0001 Bug 25276: Correct hover style of list share button in the OPAC (In reply to Lucas Gass from comment #2) > I cannot cleanly apply this patch to master: Sorry, I forgot to add the dependency on Bug 25211! Created attachment 103695 [details] [review] Bug 25276: Correct hover style of list share button in the OPAC This patch adds missing "btn" classes to the OPAC share button so that its style is consistent with similar controls. The patch also makes some general changes to the OPAC CSS to make sure link color and hover color are applied with enough specificity. This corrects the hover color of the share button but should not change any other existing style. To test you should have the OpacAllowSharingPrivateLists preference enabled. - Rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Log in to the OPAC as a user with one or more private lists. - Go to Lists -> Your lists. - In the list of lists there should be a "Share" link for each list. Hovering your mouse pointer over the link should change the style in the same way the "Edit" link does. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 103713 [details] [review] Bug 25276: Correct hover style of list share button in the OPAC This patch adds missing "btn" classes to the OPAC share button so that its style is consistent with similar controls. The patch also makes some general changes to the OPAC CSS to make sure link color and hover color are applied with enough specificity. This corrects the hover color of the share button but should not change any other existing style. To test you should have the OpacAllowSharingPrivateLists preference enabled. - Rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Log in to the OPAC as a user with one or more private lists. - Go to Lists -> Your lists. - In the list of lists there should be a "Share" link for each list. Hovering your mouse pointer over the link should change the style in the same way the "Edit" link does. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work everyone! Pushed to master for 20.05 Backported to 19.11.x for 19.11.06 |