In the list of lists in the OPAC the "Share" link doesn't have an icon.
Created attachment 103280 [details] [review] Bug 25211: Add missing share icon to OPAC lists page This patch adds a Font Awesome icon to the "Share" links on the list of lists in the OPAC. To test, apply the patch and log in to the OPAC as a user who has one or more private lists. - Go to Lists -> Your lists - In the table of your lists, each list should have a "Share" link with an icon.
Created attachment 103315 [details] [review] Bug 25211: Add missing share icon to OPAC lists page This patch adds a Font Awesome icon to the "Share" links on the list of lists in the OPAC. To test, apply the patch and log in to the OPAC as a user who has one or more private lists. - Go to Lists -> Your lists - In the table of your lists, each list should have a "Share" link with an icon. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Don't forget to enable OpacAllowSharingPrivateLists Works ok
I am trying to trest this, but I got real trouble getting the share link to show on master with and without the patch - I did switch on OpacAllowSharingPrivateLists. Can someone help?
(In reply to Katrin Fischer from comment #3) > I am trying to trest this, but I got real trouble getting the share link to > show on master with and without the patch - I did switch on > OpacAllowSharingPrivateLists. > > Can someone help? Pref on, then private link can be shared from the /cgi-bin/koha/opac-shelves.pl?op=list&category=1
Owen, on hover the 3 links have different behaviours: "Edit" is not underlined "Delete" is not underlined and red "Shared" is underlined I think "Shared" should not be underlined.
(In reply to Jonathan Druart from comment #5) > I think "Shared" should not be underlined. I have filed Bug 25276 for that issue.
Created attachment 103679 [details] [review] Bug 25211: Add missing share icon to OPAC lists page This patch adds a Font Awesome icon to the "Share" links on the list of lists in the OPAC. To test, apply the patch and log in to the OPAC as a user who has one or more private lists. - Go to Lists -> Your lists - In the table of your lists, each list should have a "Share" link with an icon. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Don't forget to enable OpacAllowSharingPrivateLists Works ok Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(In reply to Owen Leonard from comment #6) > (In reply to Jonathan Druart from comment #5) > > I think "Shared" should not be underlined. > > I have filed Bug 25276 for that issue. Thanks and sorry, I thought it came from this patch.
(In reply to Jonathan Druart from comment #5) > Owen, on hover the 3 links have different behaviours: > "Edit" is not underlined > "Delete" is not underlined and red > "Shared" is underlined > > I think "Shared" should not be underlined. That was not it, it looks like I can't save the syspref change and was missing the error (instead of success) modal: XHRPOSThttp://localhost:8081/cgi-bin/koha/svc/config/systempreferences/ [HTTP/1.1 500 Internal Server Error 58ms] Can't open /var/log/koha/kohadev/opac-error.log (Permission denied) at /usr/share/perl5/Log/Log4perl/Appender/File.pm line 143 Eval {...} at /usr/share/perl5/Log/Log4perl/Appender/File.pm line 138 Log::Log4perl::Appender::File::file_open('Log::Log4perl::Appender::File=HASH(0x55cef5d65b70)') called at /usr/share/perl5/Log/Log4perl/Appender/File.pm line 69
> That was not it, it looks like I can't save the syspref change and was > missing the error (instead of success) modal: > > XHRPOSThttp://localhost:8081/cgi-bin/koha/svc/config/systempreferences/ > [HTTP/1.1 500 Internal Server Error 58ms] > Can't open /var/log/koha/kohadev/opac-error.log (Permission denied) at > /usr/share/perl5/Log/Log4perl/Appender/File.pm line 143 > Eval {...} at /usr/share/perl5/Log/Log4perl/Appender/File.pm line 138 > Log::Log4perl::Appender::File::file_open('Log::Log4perl::Appender:: > File=HASH(0x55cef5d65b70)') called at > /usr/share/perl5/Log/Log4perl/Appender/File.pm line Filed bug 25284 for this - unrelated to the change here.
Nice work everyone! Pushed to master for 20.05
Backported to 19.11.x for 19.11.06
backported to 19.05.x for 19.05.11