Summary: | Barcode should be escaped everywhere in html code | ||
---|---|---|---|
Product: | Koha | Reporter: | Didier Gautheron <didier.gautheron> |
Component: | Circulation | Assignee: | Didier Gautheron <didier.gautheron> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | 1joynelson, gmcharlt, jonathan.druart, kyle.m.hall, lucas, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.06
|
|
Circulation function: | |||
Bug Depends on: | 14697, 24166 | ||
Bug Blocks: | |||
Attachments: |
Bug 25291: Escape barcode in ReturnClaims table display
Bug 25291: Escape barcode in ReturnClaims table display Bug 25291: Escape barcode in ReturnClaims table display Bug 25291: Escape barcode in ReturnClaims table display Bug 25291: Escape barcode in ReturnClaims table display |
Description
Didier Gautheron
2020-04-27 12:38:01 UTC
Created attachment 103782 [details] [review] Bug 25291: Escape barcode in ReturnClaims table display Created attachment 103783 [details] [review] Bug 25291: Escape barcode in ReturnClaims table display Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 103785 [details] [review] Bug 25291: Escape barcode in ReturnClaims table display Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 103794 [details] [review] Bug 25291: Escape barcode in ReturnClaims table display Test Plan: 1) Set ClaimReturnedLostValue 2) Create a checkout 3) Claim a return 4) Change the barcode to something with html inside, </a> will do Without this patch cgi-bin/koha/members/moremember.pl claim tab barcode link is broken. Created attachment 103796 [details] [review] Bug 25291: Escape barcode in ReturnClaims table display Test Plan: 1) Set ClaimReturnedLostValue 2) Create a checkout 3) Claim a return 4) Change the barcode to something with html inside, </a> will do Without this patch cgi-bin/koha/members/moremember.pl claim tab barcode link is broken. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Welcome aboard Didier :) Nice work everyone! Pushed to master for 20.05 Backported to 19.11.x for 19.11.06 doesnt apply cleanly to 19.05.x, if needed please rebase (In reply to Lucas Gass from comment #9) > doesnt apply cleanly to 19.05.x, if needed please rebase It's a fix to Bug 14697 committed after and not backported to 19.05.x |