Description
Timothy Alexis Vass
2020-04-28 11:14:35 UTC
Created attachment 103863 [details]
=== Indentations are now consistently 4 spaces and opening/closing tags are now aligned. === example: <div id="html5media"> [% FOREACH ... %] <p> ... </p> [% END %] </div> is now: <div id="html5media">
===
Whitespaces are now consistent
===
1. Occuring > < and ] [ changed to >< and ][
example:
<li> <a href="...
is now:
<li><a href="...
2. Occuring \S%] changed to \S %]
example:
ELSE%]
is now:
ELSE %]
3. Occuring # /\S changed to # / \S
example:
[% # /IF
is now
[% # / IF
4. Sometimes empty lines between concurrent [% IF %] statements changed to always
example:
[% END %]
[% IF ...
is now:
[% END %]
[% IF ...
5. Occuring ,\S changed to , \S
example:
function(d,s,id)
is now:
function(d, s, id)
6. Occuring IF \(\S.+\S\) changed to IF \( \S.+\S\ )
example:
IF (SeparateHoldings)
is now:
IF ( SeparateHoldings )
Seems like the first part of the comment was different from the commit message, it should be: === Indentations are now consistently 4 spaces and otherwise correct === example: <div id="html5media"> [% FOREACH ... %] <p> ... </p> [% END %] </div> is now: <div id="html5media"> [% FOREACH ... %] <p> ... </p> [% END %] </div> I'm marking this "Failed QA" so that this patch can wait for an amended commit message as we discussed on IRC. Created attachment 104010 [details] [review] Bug 25302: The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. To test: 1) Open an item in OPAC and see if it works. Created attachment 104029 [details] [review] Bug 25302: The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. To test: 1) Open an item in OPAC and see if it works. Created attachment 104036 [details] [review] Bug 25302: The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. To test: 1) Open an item in OPAC and see if it works. Created attachment 104299 [details] [review] Bug 25302: The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. To test: 1) Open an item in OPAC and see if it works. Created attachment 104301 [details] [review] Bug 25302: The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. To test: 1) Open an item in OPAC and see if it works. Hi Timothy, what happened here? Keen on helping you to get a patch in, catch me on IRC if you need any help. |