Summary: | Patron details page - display the alternative contact address as a block | ||
---|---|---|---|
Product: | Koha | Reporter: | David Nind <david> |
Component: | Patrons | Assignee: | David Roberts <david.roberts> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | david.roberts, gmcharlt, jonathan.druart, kyle.m.hall |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 25070 | ||
Bug Blocks: | |||
Attachments: |
Bug 25463: Patron details page - display the alternative contact address as a block
Bug 25463: Patron details page - display the alternative contact address as a block Bug 25463: Patron details page - display the alternative contact address as a block Bug 25463: Patron details page - display the alternative contact address as a block |
Description
David Nind
2020-05-12 11:11:05 UTC
This was noted when signing off bug 25070 - that bug refactors the include files for displaying address and contact information. Created attachment 105275 [details] [review] Bug 25463: Patron details page - display the alternative contact address as a block This patch changes the format of the alternative contact address to a block, instead of a list. To test: 1) Edit a patron's contact details so that the Main Address and Alternative Contact addresses are complete 2) Install the patch 3) Ensure that the AddressFormat system preference is set to US style 4) View the patron record (members/moremember.pl) and ensure that the address format in both the Contact information and Alternative address sections display identically. 5) Change the AddressFormat system preference to German style, and repeat 6) Change the AddressFormat system preference to French style, and repeat. https://bugs.koha-community.org/show_bug.cgi?id=25436 Created attachment 105278 [details] [review] Bug 25463: Patron details page - display the alternative contact address as a block This patch changes the format of the alternative contact address to a block, instead of a list. To test: 1) Edit a patron's contact details so that the Main Address and Alternative Contact addresses are complete 2) Install the patch 3) Ensure that the AddressFormat system preference is set to US style 4) View the patron record (members/moremember.pl) and ensure that the address format in both the Contact information and Alternative address sections display identically. 5) Change the AddressFormat system preference to German style, and repeat 6) Change the AddressFormat system preference to French style, and repeat. Created attachment 105279 [details] [review] Bug 25463: Patron details page - display the alternative contact address as a block This patch changes the format of the alternative contact address to a block, instead of a list. To test: 1) Edit a patron's contact details so that the Main Address and Alternative Contact addresses are complete 2) Install the patch 3) Ensure that the AddressFormat system preference is set to US style 4) View the patron record (members/moremember.pl) and ensure that the address format in both the Contact information and Alternative address sections display identically. 5) Change the AddressFormat system preference to German style, and repeat 6) Change the AddressFormat system preference to French style, and repeat. Created attachment 105318 [details] [review] Bug 25463: Patron details page - display the alternative contact address as a block This patch changes the format of the alternative contact address to a block, instead of a list. To test: 1) Edit a patron's contact details so that the Main Address and Alternative Contact addresses are complete 2) Install the patch 3) Ensure that the AddressFormat system preference is set to US style 4) View the patron record (members/moremember.pl) and ensure that the address format in both the Contact information and Alternative address sections display identically. 5) Change the AddressFormat system preference to German style, and repeat 6) Change the AddressFormat system preference to French style, and repeat. Signed-off-by: David Nind <david@davidnind.com> Thanks David Roberts! Note from testing: There is no change with the German style address, as the street number is not a separate field (probably a separate bug required for that if required). David Roberts, Could you have a look at what have been done on bug 25070? There is no more 3 files per "block", but one. See includes/member-display-address-style.inc (In reply to Jonathan Druart from comment #7) > David Roberts, Could you have a look at what have been done on bug 25070? > There is no more 3 files per "block", but one. > See includes/member-display-address-style.inc I'll be happy to once Bug 25070 gets through QA. I dont see any point in rewriting what I've done here to mirror Bug 25070 if that doesn't get through QA for whatever reason. Yes, that's why I pinged you before you wrote the patch, to make you aware of it. I also added the dependency. I should have written it explicitly in a comment here. (In reply to Jonathan Druart from comment #9) > Yes, that's why I pinged you before you wrote the patch, to make you aware > of it. > I also added the dependency. > I should have written it explicitly in a comment here. Sorry, I didn't get any message from you before I'd already written the patch. :) This appears to be fixed on master. The alternate address now is also shown as an 'address block' instead of a list of labelled fields. |