Bug 25463 - Patron details page - display the alternative contact address as a block
Summary: Patron details page - display the alternative contact address as a block
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: David Roberts
QA Contact: Testopia
URL:
Keywords:
Depends on: 25070
Blocks:
  Show dependency treegraph
 
Reported: 2020-05-12 11:11 UTC by David Nind
Modified: 2023-12-28 20:42 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 25463: Patron details page - display the alternative contact address as a block (11.65 KB, patch)
2020-05-22 18:53 UTC, David Roberts
Details | Diff | Splinter Review
Bug 25463: Patron details page - display the alternative contact address as a block (11.16 KB, patch)
2020-05-22 20:14 UTC, David Roberts
Details | Diff | Splinter Review
Bug 25463: Patron details page - display the alternative contact address as a block (11.13 KB, patch)
2020-05-22 20:17 UTC, David Roberts
Details | Diff | Splinter Review
Bug 25463: Patron details page - display the alternative contact address as a block (11.17 KB, patch)
2020-05-24 19:00 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Nind 2020-05-12 11:11:05 UTC
On the patron details page the address in the alternative contact section lists each address field, rather than displaying an address block.

Displaying as an address block would be more consistent with how it is shown in the contact information and alternative address sections.

For example, under contact information an address is displayed as:

  4345 Library Rd.
  Springfield, MA 44224

In the alternative contact section it displays as:

  Address: 4345 Library Rd.
  City: Springfield
  State: MA
  ZIP/Postal code: 44224
  Country: United States
Comment 1 David Nind 2020-05-12 18:10:37 UTC
This was noted when signing off bug 25070 - that bug refactors the include files for displaying address and contact information.
Comment 2 David Roberts 2020-05-22 18:53:53 UTC
Created attachment 105275 [details] [review]
Bug 25463: Patron details page - display the alternative contact address as a block

This patch changes the format of the alternative contact address to a block, instead of a list.

To test:

1) Edit a patron's contact details so that the Main Address and Alternative Contact addresses are complete
2) Install the patch
3) Ensure that the AddressFormat system preference is set to US style
4) View the patron record (members/moremember.pl) and ensure that the
address format in both the Contact information and Alternative address
sections display identically.
5) Change the AddressFormat system preference to German style, and
repeat
6) Change the AddressFormat system preference to French style, and
repeat.

https://bugs.koha-community.org/show_bug.cgi?id=25436
Comment 3 David Roberts 2020-05-22 20:14:04 UTC
Created attachment 105278 [details] [review]
Bug 25463: Patron details page - display the alternative contact address as a block

This patch changes the format of the alternative contact address to a block, instead of a list.

To test:

1) Edit a patron's contact details so that the Main Address and Alternative Contact addresses are complete
2) Install the patch
3) Ensure that the AddressFormat system preference is set to US style
4) View the patron record (members/moremember.pl) and ensure that the
address format in both the Contact information and Alternative address
sections display identically.
5) Change the AddressFormat system preference to German style, and
repeat
6) Change the AddressFormat system preference to French style, and
repeat.
Comment 4 David Roberts 2020-05-22 20:17:27 UTC
Created attachment 105279 [details] [review]
Bug 25463: Patron details page - display the alternative contact address as a block

This patch changes the format of the alternative contact address to a block, instead of a list.

To test:

1) Edit a patron's contact details so that the Main Address and Alternative Contact addresses are complete
2) Install the patch
3) Ensure that the AddressFormat system preference is set to US style
4) View the patron record (members/moremember.pl) and ensure that the
address format in both the Contact information and Alternative address
sections display identically.
5) Change the AddressFormat system preference to German style, and
repeat
6) Change the AddressFormat system preference to French style, and
repeat.
Comment 5 David Nind 2020-05-24 19:00:03 UTC
Created attachment 105318 [details] [review]
Bug 25463: Patron details page - display the alternative contact address as a block

This patch changes the format of the alternative contact address to a block, instead of a list.

To test:

1) Edit a patron's contact details so that the Main Address and Alternative Contact addresses are complete
2) Install the patch
3) Ensure that the AddressFormat system preference is set to US style
4) View the patron record (members/moremember.pl) and ensure that the
address format in both the Contact information and Alternative address
sections display identically.
5) Change the AddressFormat system preference to German style, and
repeat
6) Change the AddressFormat system preference to French style, and
repeat.

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2020-05-24 19:03:31 UTC
Thanks David Roberts!

Note from testing: There is no change with the German style address, as the street number is not a separate field (probably a separate bug required for that if required).
Comment 7 Jonathan Druart 2020-05-25 07:59:28 UTC
David Roberts, Could you have a look at what have been done on bug 25070?
There is no more 3 files per "block", but one.
See includes/member-display-address-style.inc
Comment 8 David Roberts 2020-05-25 13:11:13 UTC
(In reply to Jonathan Druart from comment #7)
> David Roberts, Could you have a look at what have been done on bug 25070?
> There is no more 3 files per "block", but one.
> See includes/member-display-address-style.inc

I'll be happy to once Bug 25070 gets through QA. I dont see any point in rewriting what I've done here to mirror Bug 25070 if that doesn't get through QA for whatever reason.
Comment 9 Jonathan Druart 2020-05-25 13:32:17 UTC
Yes, that's why I pinged you before you wrote the patch, to make you aware of it. 
I also added the dependency.
I should have written it explicitly in a comment here.
Comment 10 David Roberts 2020-05-25 13:33:42 UTC
(In reply to Jonathan Druart from comment #9)
> Yes, that's why I pinged you before you wrote the patch, to make you aware
> of it. 
> I also added the dependency.
> I should have written it explicitly in a comment here.

Sorry, I didn't get any message from you before I'd already written the patch. :)
Comment 11 Katrin Fischer 2023-02-26 12:17:56 UTC
This appears to be fixed on master. The alternate address now is also shown as an 'address block' instead of a list of labelled fields.