|
Description
Julian Maurice
2020-05-14 12:36:10 UTC
Created attachment 104879 [details] [review] Bug 25503: Add option to export items bundle contents in checkouts table This patch depends on bug 24023 Test plan: 1. Apply bug 24023 + this patch, run updatedatabase && update_dbix. 2. Enable system preference ExportCircHistory 3. Create a biblio record with one item 4. On the biblio details page, click on 'Edit -> Link elements'. Link at least one item 5. Check out the item created at step 3 6. In the checkouts table, check the box in column "Export", choose export format 'MARC with items', check "Export items bundle contents" and click on "Export" button The exported file should contain the biblio and item created at step 3, but also the item linked at step 4 with its biblio record Need signoff ? This is on my target list to rebase against the 28854 reworking of the original code in 24023 Created attachment 140901 [details] [review] Bug 25503: Add option to export items bundle contents in checkouts table Test plan: 1. Enable system preference ExportCircHistory 2. Create an item bundle (see bug 28854 comment 458) 3. Check out the item bundle 4. In the checkouts table, check the box in column "Export", choose export format 'MARC with items', check "Export items bundle contents" and click on "Export" button The exported file should contain the biblio and item created at step 2, but also the biblio and items that are part of the bundle note for the test plan: at step 6, I would suggest to add precision on which "export button" to use. e.g. Below the checkout lists, choose export format 'MARC with items', check "Export items bundle contents" and click on "Export" button It's work with these steps Test plan: 1. Apply bug 25503 2. Enable system preference ExportCircHistory 2. Create an item bundle (see bug 28854 comment 458) 3. Check out the item bundle 4. In the checkouts table, check the box in column "Export", Below the checkout lists, choose export format 'MARC with items', check "Export items bundle contents" and click on "Export" button The exported file should contain the biblio and item created at step 2, but also the biblio and items that are part of the bundle. Created attachment 140956 [details] [review] Bug 25503: Add option to export items bundle contents in checkouts table Test plan: 1. Enable system preference ExportCircHistory 2. Create an item bundle (see bug 28854 comment 458) 3. Check out the item bundle 4. In the checkouts table, check the box in column "Export", choose export format 'MARC with items', check "Export items bundle contents" and click on "Export" button The exported file should contain the biblio and item created at step 2, but also the biblio and items that are part of the bundle Signed-off-by: Marie-Luce <marie-luce.laflamme@inlibro.com> Changing to Signed-off then. Thanks Marie-Luce :) Created attachment 141206 [details] [review] Bug 25503: Add option to export items bundle contents in checkouts table Test plan: 1. Enable system preference ExportCircHistory 2. Create an item bundle (see bug 28854 comment 458) 3. Check out the item bundle 4. In the checkouts table, check the box in column "Export", choose export format 'MARC with items', check "Export items bundle contents" and click on "Export" button The exported file should contain the biblio and item created at step 2, but also the biblio and items that are part of the bundle Signed-off-by: Marie-Luce <marie-luce.laflamme@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> This works nicely. Maybe the UI could improved a little bit to separate the options visually a little better, but not a blocker here. Comment on attachment 141206 [details] [review] Bug 25503: Add option to export items bundle contents in checkouts table Review of attachment 141206 [details] [review]: ----------------------------------------------------------------- ::: Koha/Exporter/Record.pm @@ +132,4 @@ > record => $record, > embed_items => 1, > biblionumber => $biblionumber, > + itemnumbers => $itemnumbers, Could we have some test for this particular change that feels like fixing a bug? Thanks! Created attachment 142715 [details] [review] Bug 25503: Add option to export items bundle contents in checkouts table Test plan: 1. Enable system preference ExportCircHistory 2. Create an item bundle (see bug 28854 comment 458) 3. Check out the item bundle 4. In the checkouts table, check the box in column "Export", choose export format 'MARC with items', check "Export items bundle contents" and click on "Export" button The exported file should contain the biblio and item created at step 2, but also the biblio and items that are part of the bundle Signed-off-by: Marie-Luce <marie-luce.laflamme@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marie-Luce <marie-luce.laflamme@inlibro.com> Created attachment 143165 [details] [review] Bug 25503: Make Koha::Exporter::Record tests pass with unimarc Created attachment 143166 [details] [review] Bug 25503: Add failing test for _get_biblio_for_export Created attachment 143167 [details] [review] Bug 25503: Make _get_biblio_for_export test pass Created attachment 143168 [details] [review] Bug 25503: Add option to export items bundle contents in checkouts table Test plan: 1. Enable system preference ExportCircHistory 2. Create an item bundle (see bug 28854 comment 458) 3. Check out the item bundle 4. In the checkouts table, check the box in column "Export", choose export format 'MARC with items', check "Export items bundle contents" and click on "Export" button The exported file should contain the biblio and item created at step 2, but also the biblio and items that are part of the bundle Signed-off-by: Marie-Luce <marie-luce.laflamme@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marie-Luce <marie-luce.laflamme@inlibro.com> (In reply to Julian Maurice from comment #17) > Created attachment 143168 [details] [review] [review] > Bug 25503: Add option to export items bundle contents in checkouts table > > Test plan: > 1. Enable system preference ExportCircHistory > 2. Create an item bundle (see bug 28854 comment 458) > 3. Check out the item bundle > 4. In the checkouts table, check the box in column "Export", > choose export format 'MARC with items', check "Export items bundle > contents" and click on "Export" button > The exported file should contain the biblio and item created at step > 2, but also the biblio and items that are part of the bundle > > Signed-off-by: Marie-Luce <marie-luce.laflamme@inlibro.com> > > Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> > > Signed-off-by: Marie-Luce <marie-luce.laflamme@inlibro.com> > Signed-off-by: Danyon Sewell <danyonsewell@catalyst.net.nz> Thanks Danyon for testing :) To completely make a signoff, see this page: https://wiki.koha-community.org/wiki/Sign_off_on_patches The quickest method might be to create a sandbox, apply the patches to it, and directly[1] on the sandboxes management interface do "actions" => "signoff patches". And it will directly add your signoff to all the patches and reattach them here. Whichever method you choose, feel free to ask for help if something looks wrong in the chat or the general list. https://koha-community.org/get-involved/irc/ https://koha-community.org/support/koha-mailing-lists/ [1] no need to actually test them again on the sandbox since you already tested them locally Created attachment 146005 [details] [review] Bug 25503: Make Koha::Exporter::Record tests pass with unimarc Signed-off-by: Marie-Luce <marie-luce.laflamme@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> https://bugs.koha-community.org/show_bug.cgi?id=25508 Created attachment 146006 [details] [review] Bug 25503: Add failing test for _get_biblio_for_export Signed-off-by: Marie-Luce <marie-luce.laflamme@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> https://bugs.koha-community.org/show_bug.cgi?id=25508 Created attachment 146007 [details] [review] Bug 25503: Make _get_biblio_for_export test pass Signed-off-by: Marie-Luce <marie-luce.laflamme@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> https://bugs.koha-community.org/show_bug.cgi?id=25508 Created attachment 146008 [details] [review] Bug 25503: Add option to export items bundle contents in checkouts table Test plan: 1. Enable system preference ExportCircHistory 2. Create an item bundle (see bug 28854 comment 458) 3. Check out the item bundle 4. In the checkouts table, check the box in column "Export", choose export format 'MARC with items', check "Export items bundle contents" and click on "Export" button The exported file should contain the biblio and item created at step 2, but also the biblio and items that are part of the bundle Signed-off-by: Marie-Luce <marie-luce.laflamme@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marie-Luce <marie-luce.laflamme@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> https://bugs.koha-community.org/show_bug.cgi?id=25508 All working as described.. QA scripts are happy and this adds some nice cleanup and improvements to the unit tests. Whilst I would have loved to see the bundle handling code in a module rather than at the controller, I understand why you did it this way in this case. Passing QA Pushed to master for 23.05. Nice work everyone, thanks! Enhancement - not backporting to 22.11.x |