Summary: | Column config table in acquisitions order does not match the acq table in baskets | ||
---|---|---|---|
Product: | Koha | Reporter: | Kelly McElligott <kelly> |
Component: | Tools | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | aleisha, arthur.suzuki, jonathan.druart, koha, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.01, 19.11.07, 19.05.12
|
|
Circulation function: | |||
Attachments: |
Bug 25557: Correct basket.pl column config
Bug 25557: Correct basket.pl column config k Bug 25557: Correct basket.pl column config |
Description
Kelly McElligott
2020-05-20 18:52:25 UTC
Created attachment 105235 [details] [review] Bug 25557: Correct basket.pl column config This patch corrects the column configuration tool for basket.pl TO TEST: 1. Go to Acquisitions and look at basket.pl 2. Open another tab and go to column configuration and try to hide some columns like Quantity. 3. See that the wrong columns are being hidden. 4. Apply patch 5. Trying hiding each column in the table and make sure the correct one is being hidden. 6. Rejoice! > 1. Go to Acquisitions and look at basket.pl Is and individual basket? "Home › Acquisitions › My Vendor › Basket My Basket (1) for My Vendor " Assuming yes. > 2. Open another tab and go to column configuration and try to hide some columns like Quantity. > 3. See that the wrong columns are being hidden. Can't reproduce. I tried to hide and show most of the columns and nothing seemed wrong. (not sure if relevant, Quantity is hidden by default, no idea where the setting is) What is the role of opening another tab? Victor, Thanks for testing. Are you attempting to hide/show the columns by using the column configuration tool? The only reason I said 'open a new tab' is so the tester can have the column configuration tool open in one tab and the table in another. To make it easier to test. (In reply to Lucas Gass from comment #3) > Are you attempting to hide/show the columns by using the column > configuration tool? Is that this thing? https://picat.drycat.fr/gallery#ZxsjxojK/D7urRk7F.png > Is that this thing? https://picat.drycat.fr/gallery#ZxsjxojK/D7urRk7F.png Victor, No, I am referring to the Configure columns tool at Koha Admin > Configure columns. /cgi-bin/koha/admin/columns_settings.pl https://snipboard.io/Hk0N7V.jpg Created attachment 105421 [details] [review] Bug 25557: Correct basket.pl column config This patch corrects the column configuration tool for basket.pl TO TEST: 1. Go to Acquisitions and look at basket.pl 2. Open another tab and go to column configuration and try to hide some columns like Quantity. 3. See that the wrong columns are being hidden. 4. Apply patch 5. Trying hiding each column in the table and make sure the correct one is being hidden. 6. Rejoice! Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> (In reply to Lucas Gass from comment #5) > No, I am referring to the Configure columns tool at Koha Admin > Configure > columns. > > /cgi-bin/koha/admin/columns_settings.pl > > https://snipboard.io/Hk0N7V.jpg Hooooooo > 3. See that the wrong columns are being hidden. Indeed, nonsense can happen! > 6. Rejoice! It works! :D Created attachment 105425 [details] [review] k Created attachment 105426 [details] [review] Bug 25557: Correct basket.pl column config This patch corrects the column configuration tool for basket.pl TO TEST: 1. Go to Acquisitions and look at basket.pl 2. Open another tab and go to column configuration and try to hide some columns like Quantity. 3. See that the wrong columns are being hidden. 4. Apply patch 5. Trying hiding each column in the table and make sure the correct one is being hidden. 6. Rejoice! Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> *** Bug 25714 has been marked as a duplicate of this bug. *** Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.01 backported to 19.11.x for 19.11.07 Backported to 19.05.x branch for 19.05.12 Hello, well done for this correction! I was looking forward it :), but our Koha is in French, so the column names are in French in the basket but not the display in the column settings. So I thought I could do the translation on pootle but I can't find the file columns_settings.yml. Is it possible to translate the column names ? Thanks Sonia Hi Sonia, Non you cannot modify "columname" from the yaml, and you should not. It's how we map the settings of the table from the template with the yml, it's more an "ID" than a name. You should open an enhancement request for that, but it's not trivial to implement. Hi Jonathan :) I don't want to change the name in the yml, I just want to know if we could translate the display in pootle to have it in French. As you can see in the screen shot, it's sometimes difficult to know exactly which column is which.. https://snipboard.io/lZvsrA.jpg Do you think it's possible ? (By the way, I realize that "replacement price" and "recommended retail price" are translated by "prix public" and that is confusing.. I can at least change that !) (In reply to Koha Team University Lyon 3 from comment #17) > Hi Jonathan :) > I don't want to change the name in the yml, I just want to know if we could > translate the display in pootle to have it in French. > As you can see in the screen shot, it's sometimes difficult to know exactly > which column is which.. > https://snipboard.io/lZvsrA.jpg > > Do you think it's possible ? > > (By the way, I realize that "replacement price" and "recommended retail > price" are translated by "prix public" and that is confusing.. I can at > least change that !) Hi, we recently discussed ways to make those translatable on IRC, but concluded that the first step would be to make the English descriptions nice too, as they are more "code like" at the moment. I think it would be a great to have that. Could you please file a separate bug report for it? |