|
Description
Donna
2020-05-28 15:51:35 UTC
Great idea. I also support this idea. If it is some reason decided that we should not allow this, then we should update request.pl to make it clear that date can't be changed. As it is now, it lets one pick a new expiration date on a waiting hold but when you click Update it doesn't save. I support this idea as well. It's been a main request from our front-line staff that are assisting our patrons with contact-less hold pickup service during COVID. The ability to add a few days would aid in providing excellent customer service and patron goodwill. I agree with above, and it would nice to add some reporting on this. If we find we are adjusting the expiration dates too much, we can change our default settings. This is a great idea and would greatly benefit our patrons - especially now given the pandemic but I also see plenty of need after the fact. It could be used to support a number of programs and/or services. The expiration date appears as editable on master now - but changes don't save. I have filed bug 26656 for this mentioning this bug. This is an issue for us as well, we allow extra time for patron's to pick up ILLs so we would like to be able to edit the field as appropriate. Ed This is a fantastic idea. Like Ed, we allow patrons to pick up ILLs for as long as their ILL item is in the building, which is 30+ days. In non-pandemic times, regular holds are hold available for 4 days. Individual adjustment of time on holdshelf would save us a lot of fiddling. I support this idea also. As above, it's been a main request from our front-line staff that are assisting our patrons with contact-less hold pickup service during COVID. The ability to add a few days would aid in providing excellent customer service and patron goodwill. It would also be useful to have this ability once we return to 'normal' hold processes. I also would like to add my support to this request. All the complications with holds pickup in the time of COVID have made this something that would be very helpful! Great suggestion. We really need this functionality at our library. As it is now, staff has to use a clunky workaround which is not efficient. Created attachment 122922 [details] [review] Bug 25619: Add ability to adjust expiration date for waiting holds There are times when an item that is waiting for pickup needs to have the expiration date extended. This would give staff the ability to modify one by one, as needed, the reserves.expirationdate for a given item awaiting pickup. Test Plan: 1) Place a hold, trap an item for it such that is is waiting 2) Attempt to update the expiration date 3) Note the new date is not saved 4) Apply this patch, restart all the things! 5) Attempt to update the expiration date 6) The new date should be saved! Created attachment 122923 [details] [review] Bug 25619: Add ability to adjust expiration date for waiting holds There are times when an item that is waiting for pickup needs to have the expiration date extended. This would give staff the ability to modify one by one, as needed, the reserves.expirationdate for a given item awaiting pickup. Test Plan: 1) Place a hold, trap an item for it such that is is waiting 2) Attempt to update the expiration date 3) Note the new date is not saved 4) Apply this patch, restart all the things! 5) Attempt to update the expiration date 6) The new date should be saved! Created attachment 122924 [details] [review] Bug 25619: Unit Tests Created attachment 122929 [details] [review] Bug 25619: Add ability to adjust expiration date for waiting holds There are times when an item that is waiting for pickup needs to have the expiration date extended. This would give staff the ability to modify one by one, as needed, the reserves.expirationdate for a given item awaiting pickup. Test Plan: 1) Place a hold, trap an item for it such that is is waiting 2) Attempt to update the expiration date 3) Note the new date is not saved 4) Apply this patch, restart all the things! 5) Attempt to update the expiration date 6) The new date should be saved! Signed-off-by: Abbey Holt <aholt@dubuque.lib.ia.us> Created attachment 122930 [details] [review] Bug 25619: Unit Tests Signed-off-by: Abbey Holt <aholt@dubuque.lib.ia.us> Created attachment 123043 [details] [review] Bug 25619: (QA follow-up) Fix subtest description *** Bug 26656 has been marked as a duplicate of this bug. *** Created attachment 123693 [details] [review] Bug 25619: Add ability to adjust expiration date for waiting holds There are times when an item that is waiting for pickup needs to have the expiration date extended. This would give staff the ability to modify one by one, as needed, the reserves.expirationdate for a given item awaiting pickup. Test Plan: 1) Place a hold, trap an item for it such that is is waiting 2) Attempt to update the expiration date 3) Note the new date is not saved 4) Apply this patch, restart all the things! 5) Attempt to update the expiration date 6) The new date should be saved! Signed-off-by: Abbey Holt <aholt@dubuque.lib.ia.us> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 123694 [details] [review] Bug 25619: Unit Tests Signed-off-by: Abbey Holt <aholt@dubuque.lib.ia.us> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 123695 [details] [review] Bug 25619: (QA follow-up) Fix subtest description Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 123779 [details] [review] Bug 25619: Adjust POD Created attachment 124120 [details] [review] Bug 25619: Add ability to adjust expiration date for waiting holds There are times when an item that is waiting for pickup needs to have the expiration date extended. This would give staff the ability to modify one by one, as needed, the reserves.expirationdate for a given item awaiting pickup. Test Plan: 1) Place a hold, trap an item for it such that is is waiting 2) Attempt to update the expiration date 3) Note the new date is not saved 4) Apply this patch, restart all the things! 5) Attempt to update the expiration date 6) The new date should be saved! Signed-off-by: Abbey Holt <aholt@dubuque.lib.ia.us> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 124121 [details] [review] Bug 25619: Unit Tests Signed-off-by: Abbey Holt <aholt@dubuque.lib.ia.us> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 124122 [details] [review] Bug 25619: (QA follow-up) Fix subtest description Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 124123 [details] [review] Bug 25619: Adjust POD Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 124124 [details] [review] Bug 25619: Adjust POD and move date check before logging Potentially we could have logged a change when no date was passed. This patch moves the test before logging and updates POD Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.04 Unit test shows a warning : t/db_dependent/Holds.t .. 71/73 Use of uninitialized value $_ in concatenation (.) or string at t/db_dependent/Holds.t line 1432. Strange $_ var out of nowhere ? Pushed to 20.11.x for 20.11.10 Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. |