Summary: | Translation issues with OPAC problem reports (status and 'sent to') | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | I18N/L10N | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Martin Renvoize <martin.renvoize> |
Severity: | minor | ||
Priority: | P5 - low | CC: | aleisha, didier.gautheron, f.demians, jonathan.druart, lucas, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00
|
|
Bug Depends on: | 4461 | ||
Bug Blocks: | |||
Attachments: |
Bug 25626: Fix untranslatable strings on the 'OPAC problem reports' admin
Bug 25626: Fix untranslatable strings on the 'OPAC problem reports' admin Bug 25626: Fix untranslatable strings on the 'OPAC problem reports' admin |
Description
Katrin Fischer
2020-05-31 12:17:32 UTC
Created attachment 105456 [details] [review] Bug 25626: Fix untranslatable strings on the 'OPAC problem reports' admin The 'Sent to' and 'Status' column values were not translatable. Test plan: Translate the interface Report some problems at the OPAC Go to the admin page and notice that all the columns are now translated Hi Maybe it should use a default case for report.recipient too, if db enum is modified? I think if someone changes the db values, they need to take care of the templates as well - this should work with jQuery too. Created attachment 108343 [details] [review] Bug 25626: Fix untranslatable strings on the 'OPAC problem reports' admin The 'Sent to' and 'Status' column values were not translatable. Test plan: Translate the interface Report some problems at the OPAC Go to the admin page and notice that all the columns are now translated Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 108625 [details] [review] Bug 25626: Fix untranslatable strings on the 'OPAC problem reports' admin The 'Sent to' and 'Status' column values were not translatable. Test plan: Translate the interface Report some problems at the OPAC Go to the admin page and notice that all the columns are now translated Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Good catch, clear fix. Passing QA Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.04 missing dependencies, not backported to 19.11.x |