| Summary: | Internet Explorer: unable to save patron edits or view patron checkouts | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Janet McGowan <janet.mcgowan> |
| Component: | Browser compatibility | Assignee: | David Cook <dcook> |
| Status: | CLOSED WONTFIX | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | dcook |
| Version: | 19.11 | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26305 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
|
Description
Janet McGowan
2020-06-18 11:20:54 UTC
For what it's worth this problem doesn't seem to affect Microsoft's new Chromium-based version, Version 83.0.x, which my Windows computer installed without asking me. (In reply to Janet McGowan from comment #0) > This is on the staff interface. > On 19.11 sites using Internet Explorer 11 we have found 2 issues: > > - /members/memberentry.pl make an edit to a patron record and click Save. > The page does not save. This is cause by a JavaScript error stemming from a change to members.js in Bug 14570 - Make it possible to add multiple guarantors to a record. Line 169 of the file introduces the use of template literals (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals) which are unsupported in Internet Explorer 11 and before. I'm inclined not to make accommodations for a browser which is so old. Internet Explorer 11 was first released in 2013. Since then two newer Microsoft browsers have been released: Edge in 2015, updated in 2019 to the Chromium-based version. The latest version of Edge is available for Windows 7, 8, and 10. > - If a user has checkouts, on /members/moremember.pl in the issues table no > issues are displayed. Click on Always show checkouts immediately and no > issues are displayed. I could not reproduce this problem even in IE11. Iirc we are not officially supporting IE for the staff interface, but only for the browser. But could only locate a note in the manual: https://koha-community.org/manual/20.05/en/html/intro.html?highlight=explorer Is support of browser versions something we should discuss at the next meeting? I'll be fixing this (sooner or later) locally, since we have many clients that use IE 11. (Many of these clients having their browser usage forced on them by corporate IT policies.) I'll submit my patches here whether or not the community chooses to accept them. Maybe we should default me as the Assignee for the "Browser compatibility" component, as I'm going to be supporting IE for as long as I work at Prosentient Systems. Admittedly despite me saying that I'd look at fixing it, I haven't had the time, and based on the info from Owen, it might not be trivial to do such a fix. Ok looking at this again... Using https://babeljs.io/, it's suggesting the following. Replace: $(`.guarantor-details[data-borrowernumber=${borrower.borrowernumber}]`).length; With: (".guarantor-details[data-borrowernumber=".concat(borrower.borrowernumber, "]")).length; However, I notice ./koha-tmpl/opac-tmpl/lib/kjua/lib/dom.js uses template literals as well, and there might be other Javascript that does too. As Owen said, really there's no reason people should be using computers without Edge, and Edge supports newer Javascript, so I think the best solution might actually be to push back on Intranet users and advise that the Koha Intranet isn't fully compatible with older browsers like IE 11. |