Summary: | Typo "streetype" in member-main-address-style.inc | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | aleisha, fridolin.somers, jonathan.druart, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00 20.05.01
|
|
Circulation function: | |||
Bug Depends on: | 25070, 25839 | ||
Bug Blocks: | |||
Attachments: |
Bug 25842: Fix typo streetype in member-main-address-style.inc
Bug 25842: Fix typo streetype in member-main-address-style.inc |
Description
Owen Leonard
2020-06-22 12:57:49 UTC
(In reply to Owen Leonard from comment #0) > While not error-causing, they should be corrected for consistency. Oh there is an error : field as mandatory in BorrowerMandatoryField does not work :( Created attachment 106179 [details] [review] Bug 25842: Fix typo streetype in member-main-address-style.inc There are several more instances of the incorrect variable "streetype" in member-main-address-style.inc. Must be corrected with DB column name "streettype" in order to be able to set this field as mandatory. See also : Bug 25839 - Typo patron.streetype in member-main-address-style.inc Test plan : 1) Add "streettype" in system preference "BorrowerMandatoryField" 2) Create a new patron 3) Without patch "Street type" field is not mandatory/required, with patch it is 4) Remove "streettype" from system preference "BorrowerMandatoryField" 5) Create a new patron 6) Check "Street type" field is not mandatory/required 7) Select a value and save 8) Edit again patron 9) Check value is selected Created attachment 106181 [details] [review] Bug 25842: Fix typo streetype in member-main-address-style.inc There are several more instances of the incorrect variable "streetype" in member-main-address-style.inc. Must be corrected with DB column name "streettype" in order to be able to set this field as mandatory. See also : Bug 25839 - Typo patron.streetype in member-main-address-style.inc Test plan : 1) Add "streettype" in system preference "BorrowerMandatoryField" 2) Create a new patron 3) Without patch "Street type" field is not mandatory/required, with patch it is 4) Remove "streettype" from system preference "BorrowerMandatoryField" 5) Create a new patron 6) Check "Street type" field is not mandatory/required 7) Select a value and save 8) Edit again patron 9) Check value is selected Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Needed for 20.05.01. Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.01 missing dependencies, not backported to 19.11.x |