Bug 25842

Summary: Typo "streetype" in member-main-address-style.inc
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Fridolin Somers <fridolin.somers>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: aleisha, fridolin.somers, jonathan.druart+koha, testopia
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Text to go in the release notes:
Version(s) released in:
20.11.00 20.05.01
Bug Depends on: 25070, 25839    
Bug Blocks:    
Attachments: Bug 25842: Fix typo streetype in member-main-address-style.inc
Bug 25842: Fix typo streetype in member-main-address-style.inc

Description Owen Leonard 2020-06-22 12:57:49 UTC
There are several more instances of the incorrect variable "streetype" in member-main-address-style.inc. While not error-causing, they should be corrected for consistency.
Comment 1 Fridolin Somers 2020-06-23 07:28:07 UTC
(In reply to Owen Leonard from comment #0)
> While not error-causing, they should be corrected for consistency.
Oh there is an error : field as mandatory in  BorrowerMandatoryField does not work :(
Comment 2 Fridolin Somers 2020-06-23 07:33:43 UTC
Created attachment 106179 [details] [review]
Bug 25842: Fix typo streetype in member-main-address-style.inc

There are several more instances of the incorrect variable "streetype" in member-main-address-style.inc. Must be corrected with DB column name "streettype" in order to be able to set this field as mandatory.

See also :
Bug 25839 - Typo patron.streetype in member-main-address-style.inc

Test plan :
1) Add "streettype" in system preference "BorrowerMandatoryField"
2) Create a new patron
3) Without patch "Street type" field is not mandatory/required, with
   patch it is
4) Remove "streettype" from system preference "BorrowerMandatoryField"
5) Create a new patron
6) Check "Street type" field is not mandatory/required
7) Select a value and save
8) Edit again patron
9) Check value is selected
Comment 3 Jonathan Druart 2020-06-23 08:17:27 UTC
Created attachment 106181 [details] [review]
Bug 25842: Fix typo streetype in member-main-address-style.inc

There are several more instances of the incorrect variable "streetype" in member-main-address-style.inc. Must be corrected with DB column name "streettype" in order to be able to set this field as mandatory.

See also :
Bug 25839 - Typo patron.streetype in member-main-address-style.inc

Test plan :
1) Add "streettype" in system preference "BorrowerMandatoryField"
2) Create a new patron
3) Without patch "Street type" field is not mandatory/required, with
   patch it is
4) Remove "streettype" from system preference "BorrowerMandatoryField"
5) Create a new patron
6) Check "Street type" field is not mandatory/required
7) Select a value and save
8) Edit again patron
9) Check value is selected

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2020-06-23 08:18:17 UTC
Needed for 20.05.01.
Comment 5 Jonathan Druart 2020-06-23 08:30:08 UTC
Pushed to master for 20.11, thanks to everybody involved!
Comment 6 Jonathan Druart 2020-06-23 08:40:58 UTC
backported to 20.05.x for 20.05.01
Comment 7 Aleisha Amohia 2020-06-24 00:29:40 UTC
missing dependencies, not backported to 19.11.x