| Summary: | Bug in ill_requests patch schema | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | REST API | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | aleisha, alex, lucas, magnus, tomascohen, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.03, 19.11.09, 19.05.15
|
|
| Circulation function: | |||
| Bug Depends on: | 20563, 21063 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 25944: Schema fix for illrequests route
Bug 25944: Schema fix for illrequests route Bug 25944: Schema fix for illrequests route |
||
|
Description
Martin Renvoize (ashimema)
2020-07-07 12:12:45 UTC
Created attachment 106631 [details] [review] Bug 25944: Schema fix for illrequests route The illrequests path was missing the `comments` and `status_alias` embedable relations in the path specification. Test plan: 1/ Ensure you have the latest Mojolicious + OpenAPI modules installed. 2/ Navigate to the ill requests page and note that the table is empty. 3/ Note that under the networking tab in your browsers developer tools that the api call fails with a 400 error. 4/ Apply the patch 5/ Refresh the page 6/ The table should now load and the api route should return a proper 200 response. 7/ Signoff Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 106849 [details] [review] Bug 25944: Schema fix for illrequests route The illrequests path was missing the `comments` and `status_alias` embedable relations in the path specification. Test plan: 1/ Ensure you have the latest Mojolicious + OpenAPI modules installed. 2/ Navigate to the ill requests page and note that the table is empty. 3/ Note that under the networking tab in your browsers developer tools that the api call fails with a 400 error. 4/ Apply the patch 5/ Refresh the page 6/ The table should now load and the api route should return a proper 200 response. 7/ Signoff Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Magnus Enger <magnus@libriotech.no> Applied the patch to a production server that was having the 400 error on the main ILL page, and the error was gone. Tested on a regular Debian package install running version 19.11.07. I'd say this fixes a pretty major bug for libraries using ILL. Created attachment 106850 [details] [review] Bug 25944: Schema fix for illrequests route The illrequests path was missing the `comments` and `status_alias` embedable relations in the path specification. Test plan: 1/ Ensure you have the latest Mojolicious + OpenAPI modules installed. 2/ Navigate to the ill requests page and note that the table is empty. 3/ Note that under the networking tab in your browsers developer tools that the api call fails with a 400 error. 4/ Apply the patch 5/ Refresh the page 6/ The table should now load and the api route should return a proper 200 response. 7/ Signoff Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Magnus Enger <magnus@libriotech.no> Applied the patch to a production server that was having the 400 error on the main ILL page, and the error was gone. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 20.11, thanks everyone. Please backport to 20.05 and 19.11. ILL is broken. backported to 20.05.x for 20.05.03 backported to 19.11.x for 19.11.09 Backported to 19.05.x branch for 19.05.15 |