Summary: | Holds.t is failing randomly | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | aleisha, lucas, martin.renvoize, victor |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.03, 19.11.09, 19.05.15
|
|
Circulation function: | |||
Attachments: |
Bug 26043: Fix random failure from Holds.t
Bug 26043: Fix random failure from Holds.t |
Description
Jonathan Druart
2020-07-22 10:53:28 UTC
Created attachment 107178 [details] [review] Bug 26043: Fix random failure from Holds.t # Failed test 'Test ModReserveMinusPriority()' # at t/db_dependent/Holds.t line 202. # got: undef # expected: '1605' # Looks like you failed 1 test of 66. It is coming from Koha::Patron->holds that is ordering by reservedate, so "sometimes" they are ordered in reverse (at least it's my understanding of the problem). Test plan: Run the test file several times (from 20 to 60x), it must never fail with this patch Created attachment 107829 [details] [review] Bug 26043: Fix random failure from Holds.t # Failed test 'Test ModReserveMinusPriority()' # at t/db_dependent/Holds.t line 202. # got: undef # expected: '1605' # Looks like you failed 1 test of 66. It is coming from Koha::Patron->holds that is ordering by reservedate, so "sometimes" they are ordered in reverse (at least it's my understanding of the problem). Test plan: Run the test file several times (from 20 to 60x), it must never fail with this patch Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Verified the tests is still testing for what it should be with the code update Varified that the tests pass consistently over multiple runs. Code is clear and easy to follow.. Passing QA Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.03 backported to 19.11.x for 19.11.09 Backported to 19.05.x branch for 19.05.15 |