|
Description
Jonathan Druart
2020-07-29 10:30:19 UTC
Created attachment 107483 [details] [review] Bug 26080: Use the task queue for batch delete biblios This patch takes advantage of the task queue to delegate the batch delete biblios tool. Test plan: Delete bibliographic records using the batch record deletion tool Confirm that the job is now delegated to the task queue and that everything else is working as before Created attachment 107484 [details] [review] Bug 26080: Some refactoring A new include file is created per background job to avoid background_jobs.tt to grow too much Created attachment 107485 [details] [review] Bug 26080: Use the task queue for batch delete authorities Same as the first patch, for authorities Test plan: Delete authority records using the batch record deletion tool Confirm that the job is now delegated to the task queue and that everything else is working as before patch does not apply error: sha1 information is lacking or useless (Koha/BackgroundJob.pm). error: could not build fake ancestor Patch failed at 0001 Bug 26080: Use the task queue for batch delete biblios hint: Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-26080-Use-the-task-queue-for-batch-delete-bibl-KTCIJD.patch Created attachment 122347 [details] [review] Bug 26080: Use the task queue for batch delete biblios This patch takes advantage of the task queue to delegate the batch delete biblios tool. Test plan: Delete bibliographic records using the batch record deletion tool Confirm that the job is now delegated to the task queue and that everything else is working as before Created attachment 122348 [details] [review] Bug 26080: Some refactoring A new include file is created per background job to avoid background_jobs.tt to grow too much Created attachment 122349 [details] [review] Bug 26080: Use the task queue for batch delete authorities Same as the first patch, for authorities Test plan: Delete authority records using the batch record deletion tool Confirm that the job is now delegated to the task queue and that everything else is working as before Created attachment 123214 [details] [review] Bug 26080: Use the task queue for batch delete biblios This patch takes advantage of the task queue to delegate the batch delete biblios tool. Test plan: Delete bibliographic records using the batch record deletion tool Confirm that the job is now delegated to the task queue and that everything else is working as before Created attachment 123215 [details] [review] Bug 26080: Some refactoring A new include file is created per background job to avoid background_jobs.tt to grow too much Created attachment 123216 [details] [review] Bug 26080: Use the task queue for batch delete authorities Same as the first patch, for authorities Test plan: Delete authority records using the batch record deletion tool Confirm that the job is now delegated to the task queue and that everything else is working as before Created attachment 123989 [details] [review] Bug 26080: Use the task queue for batch delete biblios This patch takes advantage of the task queue to delegate the batch delete biblios tool. Test plan: Delete bibliographic records using the batch record deletion tool Confirm that the job is now delegated to the task queue and that everything else is working as before Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Created attachment 123990 [details] [review] Bug 26080: Some refactoring A new include file is created per background job to avoid background_jobs.tt to grow too much Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Created attachment 123991 [details] [review] Bug 26080: Use the task queue for batch delete authorities Same as the first patch, for authorities Test plan: Delete authority records using the batch record deletion tool Confirm that the job is now delegated to the task queue and that everything else is working as before Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Works super. I hope we will see all task queue refactoring in 21.11 (In reply to Fridolin Somers from comment #14) > Works super. > I hope we will see all task queue refactoring in 21.11 Test the other patches and make it happen! :) Created attachment 124408 [details] [review] Bug 26080: Use the task queue for batch delete biblios This patch takes advantage of the task queue to delegate the batch delete biblios tool. Test plan: Delete bibliographic records using the batch record deletion tool Confirm that the job is now delegated to the task queue and that everything else is working as before Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 124409 [details] [review] Bug 26080: Some refactoring A new include file is created per background job to avoid background_jobs.tt to grow too much Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 124410 [details] [review] Bug 26080: Use the task queue for batch delete authorities Same as the first patch, for authorities Test plan: Delete authority records using the batch record deletion tool Confirm that the job is now delegated to the task queue and that everything else is working as before Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 124411 [details] [review] Bug 26080: (QA follow-up) Minor template issues Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 124412 [details] [review] Bug 26080: (QA follow-up) Add POD Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 21.11, thanks to everybody involved! |