On the background jobs page, English strings are passed from the script and output directly to the template. These need to be handled in a way that is translatable. Also, dates should be output according to the dateformat system preference.
Created attachment 119597 [details] [review] Bug 28149: Improve internationalization and formatting on background jobs page This patch adds some logic to the background jobs template in order to make job status and job type translatable. Output of dates has been changed to use the KohaDates plugin, using the "with_hours" flag. This patch also modifies the page title and breadcrumbs so that if one is viewing the details of a background job the page title and breadcrumbs reflect this. I've also added inclusion of the preferences search form in the header, the default for administration pages which don't have their own search. To test, apply the patch and go to Administration -> Background jobs. - If there are no background jobs listed, submit at least one batch of bibliograhpic records and at least one batch of authorty records for modification (Tools -> Batch record modification). - In the table of background jobs, the status should be shown correctly. If you see it capitalized ("Finished") you're seeing the new string in the template which will be used for translation. - In the "Type" column, you should see either "Batch authority record modification" or "Batch bibliographic record modification" - In the "Queued," "Started," and "Ended" columns the date should be formatted according to your system's dateformat system preference, including the time. - View the details of a background job. The same changes to status and type should be seen on this page, as well as the date formatting of the date fields. - In the breadcrumbs, confirm that it shows a link to the background jobs page followed by "Details if job #X".
I'd like to sign this one but it does not apply anymore because of changes on breadcrumbs.
Created attachment 123672 [details] [review] Bug 28149: Improve internationalization and formatting on background jobs page This patch adds some logic to the background jobs template in order to make job status and job type translatable. Output of dates has been changed to use the KohaDates plugin, using the "with_hours" flag. This patch also modifies the page title and breadcrumbs so that if one is viewing the details of a background job the page title and breadcrumbs reflect this. I've also added inclusion of the preferences search form in the header, the default for administration pages which don't have their own search. To test, apply the patch and go to Administration -> Background jobs. - If there are no background jobs listed, submit at least one batch of bibliograhpic records and at least one batch of authorty records for modification (Tools -> Batch record modification). - In the table of background jobs, the status should be shown correctly. If you see it capitalized ("Finished") you're seeing the new string in the template which will be used for translation. - In the "Type" column, you should see either "Batch authority record modification" or "Batch bibliographic record modification" - In the "Queued," "Started," and "Ended" columns the date should be formatted according to your system's dateformat system preference, including the time. - View the details of a background job. The same changes to status and type should be seen on this page, as well as the date formatting of the date fields. - In the breadcrumbs, confirm that it shows a link to the background jobs page followed by "Details if job #X".
It looks great. Just missing the job status "new". It appears when job is added with koha-worker stopped.
Created attachment 123870 [details] [review] Bug 28149: (follow-up) Add string for job status "new"
Created attachment 123983 [details] [review] Bug 28149: Improve internationalization and formatting on background jobs page This patch adds some logic to the background jobs template in order to make job status and job type translatable. Output of dates has been changed to use the KohaDates plugin, using the "with_hours" flag. This patch also modifies the page title and breadcrumbs so that if one is viewing the details of a background job the page title and breadcrumbs reflect this. I've also added inclusion of the preferences search form in the header, the default for administration pages which don't have their own search. To test, apply the patch and go to Administration -> Background jobs. - If there are no background jobs listed, submit at least one batch of bibliograhpic records and at least one batch of authorty records for modification (Tools -> Batch record modification). - In the table of background jobs, the status should be shown correctly. If you see it capitalized ("Finished") you're seeing the new string in the template which will be used for translation. - In the "Type" column, you should see either "Batch authority record modification" or "Batch bibliographic record modification" - In the "Queued," "Started," and "Ended" columns the date should be formatted according to your system's dateformat system preference, including the time. - View the details of a background job. The same changes to status and type should be seen on this page, as well as the date formatting of the date fields. - In the breadcrumbs, confirm that it shows a link to the background jobs page followed by "Details if job #X". Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Created attachment 123984 [details] [review] Bug 28149: (follow-up) Add string for job status "new" Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Created attachment 124517 [details] [review] Bug 28149: Improve internationalization and formatting on background jobs page This patch adds some logic to the background jobs template in order to make job status and job type translatable. Output of dates has been changed to use the KohaDates plugin, using the "with_hours" flag. This patch also modifies the page title and breadcrumbs so that if one is viewing the details of a background job the page title and breadcrumbs reflect this. I've also added inclusion of the preferences search form in the header, the default for administration pages which don't have their own search. To test, apply the patch and go to Administration -> Background jobs. - If there are no background jobs listed, submit at least one batch of bibliograhpic records and at least one batch of authorty records for modification (Tools -> Batch record modification). - In the table of background jobs, the status should be shown correctly. If you see it capitalized ("Finished") you're seeing the new string in the template which will be used for translation. - In the "Type" column, you should see either "Batch authority record modification" or "Batch bibliographic record modification" - In the "Queued," "Started," and "Ended" columns the date should be formatted according to your system's dateformat system preference, including the time. - View the details of a background job. The same changes to status and type should be seen on this page, as well as the date formatting of the date fields. - In the breadcrumbs, confirm that it shows a link to the background jobs page followed by "Details if job #X". Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Created attachment 124518 [details] [review] Bug 28149: (follow-up) Add string for job status "new" Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.04
Does not apply easily on 20.11.x