| Summary: | Patron attribute option to display in OPAC is not compatible with PatronSelfRegistrationVerifyByEmail | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Erica Rohlfs <erica.rohlfs> |
| Component: | OPAC | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | aleisha, jonathan.druart, lucas, sally.healey, victor |
| Version: | Main | ||
| Hardware: | PC | ||
| OS: | Windows | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26219 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.04, 19.11.10
|
|
| Circulation function: | |||
| Bug Depends on: | 13757 | ||
| Bug Blocks: | 26973, 27020, 30120 | ||
| Attachments: |
Bug 26119: Enable patron's attribute edition when PatronSelfRegistrationVerifyByEmail
Bug 26119: Enable patron's attribute edition when PatronSelfRegistrationVerifyByEmail Bug 26119: Enable patron's attribute edition when PatronSelfRegistrationVerifyByEmail |
||
|
Description
Erica Rohlfs
2020-07-31 18:15:29 UTC
Created attachment 107698 [details] [review] Bug 26119: Enable patron's attribute edition when PatronSelfRegistrationVerifyByEmail There is no good reason remove the ability to edit patron's attributes if PatronSelfRegistrationVerifyByEmail is set. We cannot have them in the self-registration form (because we don't store patron's attributes during self-ref), but we can have them when a patron show/edit their information. Test plan: 0. Enable PatronSelfRegistrationVerifyByEmail and create patron's attributes that can be edited at the OPAC 1. Create a new patron using the self-reg feature => You don't have the ability to fill in the patron's attribute 2. Edit your personal details (OPAC) => Without this patch you still don't see the patron's attribute that can be edited at the OPAC => With this patch applied you can! 3. Notice the wording change on the "Modify patron attribute type" form and confirm it makes sense Created attachment 107699 [details] [review] Bug 26119: Enable patron's attribute edition when PatronSelfRegistrationVerifyByEmail There is no good reason remove the ability to edit patron's attributes if PatronSelfRegistrationVerifyByEmail is set. We cannot have them in the self-registration form (because we don't store patron's attributes during self-ref), but we can have them when a patron show/edit their information. Test plan: 0. Enable PatronSelfRegistrationVerifyByEmail and create patron's attributes that can be edited at the OPAC 1. Create a new patron using the self-reg feature => You don't have the ability to fill in the patron's attribute 2. Edit your personal details (OPAC) => Without this patch you still don't see the patron's attribute that can be edited at the OPAC => With this patch applied you can! 3. Notice the wording change on the "Modify patron attribute type" form and confirm it makes sense Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Created attachment 108318 [details] [review] Bug 26119: Enable patron's attribute edition when PatronSelfRegistrationVerifyByEmail There is no good reason remove the ability to edit patron's attributes if PatronSelfRegistrationVerifyByEmail is set. We cannot have them in the self-registration form (because we don't store patron's attributes during self-ref), but we can have them when a patron show/edit their information. Test plan: 0. Enable PatronSelfRegistrationVerifyByEmail and create patron's attributes that can be edited at the OPAC 1. Create a new patron using the self-reg feature => You don't have the ability to fill in the patron's attribute 2. Edit your personal details (OPAC) => Without this patch you still don't see the patron's attribute that can be edited at the OPAC => With this patch applied you can! 3. Notice the wording change on the "Modify patron attribute type" form and confirm it makes sense Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> I believe there is still a problem with the "display in OPAC" functionality - I filed Bug 26219 - "Display in OPAC" option not working for patron attributes for this. Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.04 backported to 19.11.x for 19.11.10 Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed. |