| Summary: | Add column configuration to the Point of sale, Items for purchase table | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | Fines and fees | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | jonathan.druart, lucas, oleonard, sally.healey |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 23354 | ||
| Bug Blocks: | 26189 | ||
| Attachments: |
Bug 26160: Make POS items table configurable
Bug 26160: Make POS items table configurable Bug 26160: Make POS items table configurable Bug 26160: (follow-up) Improve styling |
||
|
Description
Martin Renvoize (ashimema)
2020-08-06 12:11:41 UTC
Created attachment 107892 [details] [review] Bug 26160: Make POS items table configurable Created attachment 108007 [details] [review] Bug 26160: Make POS items table configurable Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Test Plan: 1) System preference: EnablePointOfSale - set to Enable 2) System preference: UseCashRegisters - set to Use 3) Administration > Accounting > Cash registers - create a new cash register for the library you're logged in as 4) Administration > Accounting > Debit types - create at least one debit type 5) Home > Point of sale - verify that all four columns exist in the Items for purchase table: Code, Description, Cost, Action 6) Administration > Additional parameters > Table settings > Point of sale - change which columns can be hidden and/or toggled 7) Home > Point of sale - verify that your choices have been implemented (columns are hidden, columns can be toggled, columns can't be toggled) 8) Repeat steps 6 and 7 for different combinations, checking that they all work. Works great, signing off. I think we should by default not print/export the Actions column, but this is currently not handled consistenty on other tables - it doesn't print for itemtypes, but it does for libraries. So not failing solely for this reason. This might also need some additional styling work - I filed bug 26189 for that as the display is not perfect right now either. Created attachment 108014 [details] [review] Bug 26160: Make POS items table configurable 1) System preference: EnablePointOfSale - set to Enable 2) System preference: UseCashRegisters - set to Use 3) Administration > Accounting > Cash registers - create a new cash register for the library you're logged in as 4) Administration > Accounting > Debit types - create at least one debit type 5) Home > Point of sale - verify that all four columns exist in the Items for purchase table: Code, Description, Cost, Action 6) Administration > Additional parameters > Table settings > Point of sale - change which columns can be hidden and/or toggled 7) Home > Point of sale - verify that your choices have been implemented (columns are hidden, columns can be toggled, columns can't be toggled) 8) Repeat steps 6 and 7 for different combinations, checking that they all work. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Added Sally's test plan. (In reply to Katrin Fischer from comment #4) > I think we should by default not print/export the Actions column, but this > is currently not handled consistenty on other tables - it doesn't print for > itemtypes, but it does for libraries. So not failing solely for this reason. > > This might also need some additional styling work - I filed bug 26189 for > that as the display is not perfect right now either. I actually asked on IRC about removing the export/print option entirely as I don't feel you would want to do that here.. but I was warned against it as it would entail changing more base code in KohaTable. I may open another bug for that sometime soon however. Thanks for the QA. [U+1F600] It does not display nicely for me: https://snipboard.io/irsbW8.jpg (In reply to Jonathan Druart from comment #7) > It does not display nicely for me: https://snipboard.io/irsbW8.jpg Katrin raised this as another bug, styling issues were present prior to this bug (I've not managed to work out how to resolve them and have asked for some help on IRC) Created attachment 108102 [details] [review] Bug 26160: (follow-up) Improve styling Minor improvements above to make dataTables styling more consistent when found within a 'fieldset class="rows"' element.. Still needs some work to get the alignment working but I've hit a dead end.. hoping someone can take a look and help. Can you move your patch to bug 26189 please? (In reply to Jonathan Druart from comment #11) > Can you move your patch to bug 26189 please? Done, thanks :) Pushed to master for 20.11, thanks to everybody involved! Enhancement will bot be backported to 20.05.x |
