The table paging, sorting, and other options on the "items for purchase" table on the Points of sale page are misaligned and don't work well with the smaller table width.
Created attachment 108106 [details] [review] Bug 26189: Improve styling of POS table headers
Need a little CSS help here guys.. I can't for the life of me work out why the label + select/inputs are wrapping over two lines.
Created attachment 108156 [details] [review] Bug 26189: unset label width in payForm
Maybe just unset the width of labels inside of #payForm?
Created attachment 108164 [details] [review] Bug 26189: Improve styling of datatables within fieldsets This patch improves the responsive layout of datatables (and tables generally) by setting layout to 'fixed' and and enabled word-wrap on table cells. We also reset the margins for datatables found inside fieldsets such that the datatable properly utilises the available space and we restore the default datatable label font weights.
Created attachment 108165 [details] [review] Bug 21689: Unset label width restriction The label width restriction within fieldsets causes issues for the datatables header. Unsetting it explicitly here resolves the line wrapping issues :)
(In reply to Lucas Gass from comment #4) > Maybe just unset the width of labels inside of #payForm? Dude! That's genius, how did I not spot that.. fixes it up perfectly :)
I received a conflict when trying to apply the patch: Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 26189: Improve styling of datatables within fieldsets
Created attachment 108743 [details] [review] Bug 26189: Improve styling of datatables within fieldsets Unset label width restriction: The label width restriction within fieldsets causes issues for the datatables header. Unsetting it explicitly here resolves the line wrapping issues :) Reset margins for datatables found inside fieldsets such that the datatable properly utilises the available space and restore the default datatable label font weights.
I've rebased and simplified the patchset. You will need to run the CSS build to test this. (If testing on a sandbox, you can use the 'Build CSS' option from the 'Actions' menu)
Created attachment 108744 [details] [review] Bug 26189: Improve styling of datatables within fieldsets Unset label width restriction: The label width restriction within fieldsets causes issues for the datatables header. Unsetting it explicitly here resolves the line wrapping issues :) Reset margins for datatables found inside fieldsets such that the datatable properly utilises the available space and restore the default datatable label font weights. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
(In reply to Martin Renvoize from comment #10) > I've rebased and simplified the patchset. > > You will need to run the CSS build to test this. (If testing on a sandbox, > you can use the 'Build CSS' option from the 'Actions' menu) No worries, thanks for the tip - it's probably paranoia but I always use 'Build CSS' if I think the patch touches anything styling-wise. Signed off. :)
(In reply to Sally from comment #12) > (In reply to Martin Renvoize from comment #10) > > I've rebased and simplified the patchset. > > > > You will need to run the CSS build to test this. (If testing on a sandbox, > > you can use the 'Build CSS' option from the 'Actions' menu) > > No worries, thanks for the tip - it's probably paranoia but I always use > 'Build CSS' if I think the patch touches anything styling-wise. > > Signed off. :) Many thanks for testing [U+1F600], very wise to use the Build CSS options, I must admit I'm terrible at remembering to mention it in the test plans.
Sally, always happy to QA patches you tested :)
Created attachment 108759 [details] [review] Bug 26189: Improve styling of datatables within fieldsets Unset label width restriction: The label width restriction within fieldsets causes issues for the datatables header. Unsetting it explicitly here resolves the line wrapping issues :) Reset margins for datatables found inside fieldsets such that the datatable properly utilises the available space and restore the default datatable label font weights. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Created attachment 108973 [details] [review] Bug 26189: Improve styling of datatables within fieldsets Unset label width restriction: The label width restriction within fieldsets causes issues for the datatables header. Unsetting it explicitly here resolves the line wrapping issues :) Reset margins for datatables found inside fieldsets such that the datatable properly utilises the available space and restore the default datatable label font weights. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.04
missing dependencies, not backported to 19.11.x