Bug 26176

Summary: AutoLocation is badly named
Product: Koha Reporter: Martin Renvoize <martin.renvoize>
Component: Architecture, internals, and plumbingAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: aude.charillon, caroline.cyr-la-rose, fridolin.somers
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:

Description Martin Renvoize 2020-08-07 11:41:17 UTC
As far as I can tell AutoLocation isn't about koha picking a library branch automatically from your login IP address as much as it's a security feature to prevent you from logging into another branch from outside an IP range.

As such, I feel the preference is either misnamed, or the description is incorrect.. either way it needs some clarification adding.
Comment 1 Katrin Fischer 2023-09-22 19:17:53 UTC
Do you have an idea for a good name?

RestrictStaffAccessByIP?
Comment 2 Martin Renvoize 2023-09-22 21:59:31 UTC
Adding some Cc's for opinions
Comment 3 Caroline Cyr La Rose 2023-09-25 13:35:10 UTC
I like RestrictStaffAccessByIP

The other ones I thought of are basically variations of the same name

- RestrictAccessByIP

- AccessRestrictionByIP (very similar to/based on SessionRestrictionByIP, maybe too similar?)

- StaffAllowByIP (based on SelfCheckAllowByIPRanges)

- ControlAccessByIP

- IPStaffAccessControl

- IPStaffAccessRestriction

If you change it, can you also change the sentence to 

"[Don't require|Require] staff to log in from a computer in the IP address range specified by their library (if any)"

(instead of .... [No|Yes]) ?
Comment 4 Aude Charillon 2023-09-29 07:54:39 UTC
I also like RestrictStaffAccessByIP - does what it says! Or, if we want to go for something a little bit shorter: ControlAccessByIP from among Caroline's suggestions.
Comment 5 Fridolin Somers 2024-04-22 09:43:37 UTC
Maybe "StaffRestrictAccessByIP" in case we add "OPACRestrictAccessByIP"