Summary: | Wrap 'items available for pick-up' note when placing a hold in the OPAC in a div element | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | OPAC | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | aleisha, brandon.jimenez, david, jonathan.druart, oleonard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.06
|
|
Circulation function: | |||
Attachments: |
Bug 26184: Add html element to note in OPAC reserve template
Bug : 26184 - element missing a proper HTML element Bug 26184: Add html element to note in OPAC reserve template Bug 26184: Add div element to 'items available' note in OPAC reserve template |
Description
Lucas Gass (lukeg)
2020-08-07 18:14:17 UTC
Created attachment 107972 [details] [review] Bug 26184: Add html element to note in OPAC reserve template Created attachment 108526 [details] [review] Bug : 26184 - element missing a proper HTML element Signed-off-by: Brandon J <brandon.jimenez@inLibro.com> to test : 2 -before applying the patch : 3 -- 1 Home (OPAC) 4 -- 2 Click on a book 5 -- 3 Click Place Hold 6 NOTE: if you don't see the text, the library has to disable hold. 7 To disable Hold: 8 -- 1 HOME (Intranet) 9 -- 2 Preferences 10 -- 3 Search for OPACHoldsIfAvailableAtPickup and turn it to "Don't allow" 11 12 - APPLY PATCH 13 - Retest (in the inspector the note is enclosed now by a SPAN tag) Hi Brandon, Thanks for looking at this and testing. Did you sign-off on this patch? Looks like you added a sign-off but didn't change the status to signed-off. Looks like you also supplied a patch which includes some changes to updatedatabase.pl, I am going to mark that patch as obsolete. Created attachment 110401 [details] [review] Bug 26184: Add html element to note in OPAC reserve template Signed-off-by: David Nind <david@davidnind.com> I signed-off using Brandon J's test plan in comment 3 - feel free to change the sign off attribution to Brandon J! Created attachment 110427 [details] [review] Bug 26184: Add div element to 'items available' note in OPAC reserve template Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Why this class name? Isn't it just a note? (In reply to Jonathan Druart from comment #8) > Why this class name? Isn't it just a note? Jonathan, would you rather the class name be something else? I don't mind changing it. class="note"? Hi Jonathan, as the stated intention here was to be able to change the text, a specific class (or id) makes more sense. With possibly changing translations hooking the jQuery on a test or word is not ideal. test = text... Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.06 enhancement, not backported to 19.11.x |