In the opac-reserve template there are these lines: [% IF at_least_one_library_not_available_for_pickup %] <br>Note: Library policy does not allow hold/pickup of an item available locally. Please come to the library to retrieve these items [% END %] This is wording that some libraries would like to change but since it is not wrapped in an HTML element is difficult. We should wrap this in an HTML element
Created attachment 107972 [details] [review] Bug 26184: Add html element to note in OPAC reserve template
Created attachment 108526 [details] [review] Bug : 26184 - element missing a proper HTML element Signed-off-by: Brandon J <brandon.jimenez@inLibro.com>
to test : 2 -before applying the patch : 3 -- 1 Home (OPAC) 4 -- 2 Click on a book 5 -- 3 Click Place Hold 6 NOTE: if you don't see the text, the library has to disable hold. 7 To disable Hold: 8 -- 1 HOME (Intranet) 9 -- 2 Preferences 10 -- 3 Search for OPACHoldsIfAvailableAtPickup and turn it to "Don't allow" 11 12 - APPLY PATCH 13 - Retest (in the inspector the note is enclosed now by a SPAN tag)
Hi Brandon, Thanks for looking at this and testing. Did you sign-off on this patch? Looks like you added a sign-off but didn't change the status to signed-off. Looks like you also supplied a patch which includes some changes to updatedatabase.pl, I am going to mark that patch as obsolete.
Created attachment 110401 [details] [review] Bug 26184: Add html element to note in OPAC reserve template Signed-off-by: David Nind <david@davidnind.com>
I signed-off using Brandon J's test plan in comment 3 - feel free to change the sign off attribution to Brandon J!
Created attachment 110427 [details] [review] Bug 26184: Add div element to 'items available' note in OPAC reserve template Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Why this class name? Isn't it just a note?
(In reply to Jonathan Druart from comment #8) > Why this class name? Isn't it just a note? Jonathan, would you rather the class name be something else? I don't mind changing it.
class="note"?
Hi Jonathan, as the stated intention here was to be able to change the text, a specific class (or id) makes more sense. With possibly changing translations hooking the jQuery on a test or word is not ideal.
test = text...
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.06
enhancement, not backported to 19.11.x