Bug 26238

Summary: Remove C4::GetLoanLength()
Product: Koha Reporter: Lari Taskula <lari.taskula>
Component: Architecture, internals, and plumbingAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low    
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 25114    
Bug Blocks:    

Description Lari Taskula 2020-08-18 16:06:27 UTC
GetLoanLength() has become a redundant subroutine. It is a subroutine that simply calls Koha::CirculationRules->get_effective_rules() and effectively returns its response. We should just use get_effective_rules() instead.

In addition, GetLoanLength() is is only being used in C4::CalcDueDate() so the change should be trivial.