Bug 26238 - Remove C4::GetLoanLength()
Summary: Remove C4::GetLoanLength()
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 25114
Blocks:
  Show dependency treegraph
 
Reported: 2020-08-18 16:06 UTC by Lari Taskula
Modified: 2020-08-18 16:06 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lari Taskula 2020-08-18 16:06:27 UTC
GetLoanLength() has become a redundant subroutine. It is a subroutine that simply calls Koha::CirculationRules->get_effective_rules() and effectively returns its response. We should just use get_effective_rules() instead.

In addition, GetLoanLength() is is only being used in C4::CalcDueDate() so the change should be trivial.