Bug 26287

Summary: get_onshelfholds_policy always uses item holdingbranch
Product: Koha Reporter: Andrew Fuerste-Henry <andrew>
Component: Hold requestsAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: gmcharlt, jonathan.druart
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 5786    
Bug Blocks:    

Description Andrew Fuerste-Henry 2020-08-24 13:53:59 UTC
In CirculationRules.pm, the subroutine get_onshelfholds_policy is written to always check the circ rules of the item's holdingbranch. This will not always match a library's desired behavior. Shouldn't this sub follow the ReservesControlBranch value instead?
Comment 1 Jonathan Druart 2020-08-25 13:37:48 UTC
That would make sense to me, maybe we should ask the mailing list?