Summary: | svc/letters/preview is not executable which prevents CGI functioning | ||
---|---|---|---|
Product: | Koha | Reporter: | David Cook <dcook> |
Component: | Architecture, internals, and plumbing | Assignee: | David Cook <dcook> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | aleisha, fridolin.somers, jonathan.druart, lucas, martin.renvoize, victor |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26384 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26382 |
||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
20.11.00, 20.05.04, 19.11.10
|
Circulation function: | |
Attachments: |
Bug 26331: Make svc/letters/preview executable
Bug 26331: Make svc/letters/preview executable Bug 26331: Make svc/letters/preview executable |
Description
David Cook
2020-09-01 05:18:54 UTC
Created attachment 109387 [details] [review] Bug 26331: Make svc/letters/preview executable Without this patch, you can't preview letters when running Koha in CGI mode. To test: 1. Run Koha as CGI (and not Plack) 2. Go to /cgi-bin/koha/tools/letter.pl?op=add_form&branchcode=&module=circulation&code=CHECKIN 3. Try to preview the notice (using a valid barcode) 4. Note in the browser console that svc/letters/preview is generating a 500 error Created attachment 109581 [details] [review] Bug 26331: Make svc/letters/preview executable Without this patch, you can't preview letters when running Koha in CGI mode. To test: 1. Run Koha as CGI (and not Plack) 2. Go to /cgi-bin/koha/tools/letter.pl?op=add_form&branchcode=&module=circulation&code=CHECKIN 3. Try to preview the notice (using a valid barcode) 4. Note in the browser console that svc/letters/preview is generating a 500 error Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Trivial ;) Looks like its the only file missing permission : find svc -not -perm -755 Created attachment 109594 [details] [review] Bug 26331: Make svc/letters/preview executable Without this patch, you can't preview letters when running Koha in CGI mode. To test: 1. Run Koha as CGI (and not Plack) 2. Go to /cgi-bin/koha/tools/letter.pl?op=add_form&branchcode=&module=circulation&code=CHECKIN 3. Try to preview the notice (using a valid barcode) 4. Note in the browser console that svc/letters/preview is generating a 500 error Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Good catch, trivial patch.. Passing QA Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.04 backported to 19.11.x for 19.11.10 Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed. |