|
Description
Kyle M Hall (khall)
2020-09-03 14:38:38 UTC
Some libraries have certain patron categories that can only do in house checkouts via SIP self check machines. In these cases, the items should not be demagnetized since the items cannot leave the library. Created attachment 109630 [details] [review] Bug 26370: Add ability to disable demagnetizing items via SIP2 for arbitrary patron categories Some libraries have certain patron categories that can only do in house checkouts via SIP self check machines. In these cases, the items should not be demagnetized since the items cannot leave the library. Created attachment 120834 [details] [review] Bug 26370: Add ability to disable demagnetizing items via SIP2 for arbitrary patron categories Some libraries have certain patron categories that can only do in house checkouts via SIP self check machines. In these cases, the items should not be demagnetized since the items cannot leave the library. Test Plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Message.t Created attachment 133144 [details] [review] Bug 26370: Add ability to disable demagnetizing items via SIP2 for arbitrary patron categories Some libraries have certain patron categories that can only do in house checkouts via SIP self check machines. In these cases, the items should not be demagnetized since the items cannot leave the library. Test Plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Message.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 133145 [details] [review] Bug 26370: (QA follow-up) Add new option to templates Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> This works well.. I've added a follow-up to add the new option to the templates. We still need to also document it on https://wiki.koha-community.org/wiki/SIP2_configuration#accounts. However, I'm not sure about the option name... it's a little opaque. `never_demagnetize`.. I think we should update it to something clearer.. perhaps `inhouse_patron_categories` or something along those lines? Lets agree on a name and then we can PQA this.. it's a trivial piece of code. Created attachment 133146 [details] [review] Bug 26370: (QA follow-up) Rename option never_demagnitize to inhouse_patron_categories Created attachment 133206 [details] [review] Bug 26370: Add ability to disable demagnetizing items via SIP2 for arbitrary patron categories Some libraries have certain patron categories that can only do in house checkouts via SIP self check machines. In these cases, the items should not be demagnetized since the items cannot leave the library. Test Plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Message.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 133207 [details] [review] Bug 26370: (QA follow-up) Rename option never_demagnitize to inhouse_patron_categories Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 133208 [details] [review] Bug 26370: (QA follow-up) Add new option to templates Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> This all works as designed and doesn't cause any regressions. Passing QA I've documented to new config option on the wiki now too :) (In reply to Martin Renvoize from comment #13) > I've documented to new config option on the wiki now too :) Awesome! Thanks! Pushed to master for 22.05, thanks to everybody involved [U+1F984] |